nestjs-query icon indicating copy to clipboard operation
nestjs-query copied to clipboard

Is this project still Alive ?

Open MarouaneMan opened this issue 3 years ago • 20 comments

All is in the title.

MarouaneMan avatar Apr 21 '22 16:04 MarouaneMan

I'm actively using it and also created multiple PR's, never got an answer on any of them.

So I don't think so :(

TriPSs avatar Apr 21 '22 19:04 TriPSs

Yeah, and I'd be interested in the maintenance of only one part of the packages, not all of them. So, if others think similarly, taking over the maintenance of all of the repo would be a difficult decision.

Scott

smolinari avatar Apr 22 '22 03:04 smolinari

@smolinari what parts are you interested in?

TriPSs avatar Apr 22 '22 07:04 TriPSs

@TriPSs - I've worked a little and am still using the Typegoose bit.

Scott

smolinari avatar Apr 22 '22 07:04 smolinari

@smolinari I do have a fork of this package here that already has some fixes and i'm planning to fix more in it.

It's not yet published some where (I published to private repo), will check if I can make some time soon to publish it somewhere, than maybe the development can continue there.

TriPSs avatar May 04 '22 09:05 TriPSs

@TriPSs I've also made a PR about a month and a half ago. Let me know when it's published publicly ;)

GP4cK avatar May 16 '22 08:05 GP4cK

@GP4cK it currently is :)

I do have to note that I created a breaking change, still need to document this, but the change is that if the item is not found is used to return null and that now throws an error.

See this commit for the change.

TriPSs avatar May 16 '22 08:05 TriPSs

I mean the npm packages. Have you published them? I couldn't find them just now...

GP4cK avatar May 16 '22 09:05 GP4cK

Yes: https://www.npmjs.com/package/@ptc-org/nestjs-query-core https://www.npmjs.com/package/@ptc-org/nestjs-query-graphql https://www.npmjs.com/package/@ptc-org/nestjs-query-typeorm https://www.npmjs.com/package/@ptc-org/nestjs-query-typegoose https://www.npmjs.com/package/@ptc-org/nestjs-query-mongoose https://www.npmjs.com/package/@ptc-org/nestjs-query-sequelize

TriPSs avatar May 16 '22 09:05 TriPSs

@TriPSs can you list your bug have been fixed i fixed 2 bug about enum type and ilike operator, i will pull request to your fork

meodemsao avatar May 29 '22 12:05 meodemsao

@meodemsao Issues/PR's that are merged/released:

  • #1504
  • #1437
  • implemented feature to disable filtering and sorting, see https://github.com/TriPSs/nestjs-query/pull/10
  • #1303
  • Fixed between filter not working when using custom allowedComparisons
  • #1495
  • #1444
  • #1450
  • #1447
  • #1445
  • feat: Added support for withDeleted in Relation decorator
  • https://github.com/TriPSs/nestjs-query/pull/4

More fixes are always welcome ❤️

TriPSs avatar May 31 '22 13:05 TriPSs

Latest version ? .v0.30.0 - 2021-09-30

Is active lib? many issues are open

This lib really helps in development, let's not let this project die, please....

daniloras avatar Jun 24 '22 05:06 daniloras

@daniloras - Did you read this thread? @TriPSs is upkeeping a fork. See here: https://github.com/doug-martin/nestjs-query/issues/1538#issuecomment-1127417301

Scott

smolinari avatar Jun 24 '22 06:06 smolinari

It's a bit sad that @doug-martin seemed to be treating this project with care and attention then suddenly completely disappeared. I know it's OS, requires time, etc., but some guidance for the future or designating new maintainers would be nice

wowczarczyk avatar Jul 01 '22 20:07 wowczarczyk

It's a bit sad that @doug-martin seemed to be treating this project with care and attention then suddenly completely disappeared. I know it's OS, requires time, etc., but some guidance for the future or designating new maintainers would be nice

I honestly find it hard to understand how some of these packages have taken so much work and then they just get abandoned... At least handing over the reigns so others can take over would be nice.

I guess you can always fork but doesn't add to the usability

ruudvanbuul avatar Jul 14 '22 20:07 ruudvanbuul

I honestly find it hard to understand how some of these packages have taken so much work and then they just get abandoned... At least handing over the reigns so others can take over would be nice.

Github really doesn't make it easy to hand over the reigns on personal repos. @doug-martin has done incredible work putting this project together, I'm sure he'd keep it up if he could. Really difficult to have to shoulder responsibility for the project when things change and it's no longer a top priority, and there's no way to set up another admin.

jamesmcglinn avatar Aug 28 '22 20:08 jamesmcglinn

@doug-martin thanks for the great project. if you want to leave, can you transfer this project to someone?

Diluka avatar Sep 09 '22 09:09 Diluka

It looks like @doug-martin has completely stopped working on code, at least code stored at Github, since July.

I'd suggest looking at @TriPSs 's fork and supporting his work going forward.

https://github.com/tripss/nestjs-query

Scott

smolinari avatar Sep 09 '22 09:09 smolinari

After seeing over the years what a frequent contributor he has been to the OpenSource community I am concerned for @doug-martin; hope all is well with him.

dvins avatar Sep 15 '22 01:09 dvins

thank you @TriPSs this is a real saviour :)

rymanso avatar Nov 10 '22 11:11 rymanso