goqu icon indicating copy to clipboard operation
goqu copied to clipboard

Bugfix/317

Open XIELongDragon opened this issue 3 years ago • 4 comments

uint64 cast to int64 caused lost of data #317

XIELongDragon avatar Dec 19 '21 14:12 XIELongDragon

Codecov Report

Merging #318 (21e069a) into master (31d438d) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   96.90%   96.91%           
=======================================
  Files          62       62           
  Lines        3488     3498   +10     
=======================================
+ Hits         3380     3390   +10     
  Misses         92       92           
  Partials       16       16           
Flag Coverage Δ
unittests 96.91% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sqlgen/expression_sql_generator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31d438d...21e069a. Read the comment docs.

codecov[bot] avatar Dec 20 '21 00:12 codecov[bot]

Any plans to merge this? :) Would be nice to have it in a future release (currently I have to do some pretty nasty workarounds to not run into this). Or is there any way how I can support to get it merged? :)

Hackfred avatar Feb 11 '22 21:02 Hackfred

Hi @Hackfred , as @mattn and @doug-martin did not come for a long time. Maybe you can use my fork before this PR is merged.

add the below line before the require ( line in your go.mod file,

replace github.com/doug-martin/goqu/v9 v9.18.0 => github.com/XIELongDragon/goqu/v9 v9.18.1

you may need to update the goqu version v9.18.0 to the version you used.

XIELongDragon avatar Feb 13 '22 06:02 XIELongDragon