pre-commit-clang-format icon indicating copy to clipboard operation
pre-commit-clang-format copied to clipboard

Add version tag to be referenced by pre-commit

Open b1ackviking opened this issue 3 years ago • 2 comments

When I try to use the hook as described in the readme, pre-commit issues the following warning message:

[WARNING] The 'rev' field of repo 'https://github.com/doublify/pre-commit-clang-format'
          appears to be a mutable reference (moving tag / branch). 
          Mutable references are never updated after first install and are not supported. 
          See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.

This basically means that using rev: master is wrong.

Although the hook does not seem to be frequently updated, it is sad to see this warning every time I commit. I suggest adding a 1.0 tag to the current HEAD of the repository.

b1ackviking avatar Apr 06 '21 13:04 b1ackviking

You can also just put an commit SHA here. But yes, pre-commit caches assuming the rev will never change, so you should never use master/main.

henryiii avatar Jul 17 '21 12:07 henryiii

+1 here, would be helpful

okainov avatar Jul 21 '21 11:07 okainov