arooo icon indicating copy to clipboard operation
arooo copied to clipboard

Scholarship related

Open Aiyesha opened this issue 2 years ago • 2 comments

What github issue is this PR for, if any?

Resolves [#468] Resolved [#346]

What does this code do, and why?

Instead of is_scholarship column, expanded to requested_scholarship, scholarship_since, and scholarship_last_checkin To facilitate if a scholarship request has been made, but waiting for approval, and to facilitate yearly check-in to see if scholarship to continue.

Since scholarship requests are tracked, can also avoid emails during the new member process when new member is waiting for a scholarship request and hasn't setup dues yet.

How is this code tested?

  1. DB Migration --> manually tested up and down
  2. New tests added for changes (or modified where appropriate)
  3. Verified UI looks okay on admin page, and new member page. Manually confirmed that "Allow scholarship", "Continue scholarship", and "Remove scholarship" buttons work as expected.

Are any database migrations required by this change?

Yes.

Because of switch from boolean to timestamp; decided to fill with 2022-07-10 which was around the time of the most recent checkin.

Are there any configuration or environment changes needed?

No.

Screenshots please :)

Admin UI for viewing who's on scholarships: image

New member page: image image

Aiyesha avatar Oct 11 '22 03:10 Aiyesha

This is awesome! Small request to add to this – if someone starts paying dues again (sets up dues) can you terminate the scholarship and record when it ended? 🙏 that's one of the big pain points right now

Imperiopolis avatar Oct 13 '22 23:10 Imperiopolis

Oh! That's a good point. I'll take a look at that.

Aiyesha avatar Oct 14 '22 01:10 Aiyesha