arooo
arooo copied to clipboard
Fix sort up/down buttons
This was broken by https://github.com/doubleunion/arooo/pull/333

maybe use this fork https://github.com/marlinpierce/jquery-datatables-rails
@compwron , Can I work on this issue?
@snpd25 Yep! Thanks! :)
@compwron , I would require a bit of guidance on how to fix this.
@snpd25 Are you having trouble
- replicating/seeing the issue
- deciding what the best solution would look like
- writing the code to implement the solution
Since async communication is slow, I'll try to answer all of them-
- To see the issue, visit production or staging (staging login info is in the readme)
- What should the fix be? Show any kind of indicator which implies to the user that the column is sortable- you get to decide! Anything better than the current weird boxes will be a win :)
- How to write the code- I would start by reading the https://github.com/rweng/jquery-datatables-rails readme and docs and seeing how the arooo code is using it, and trying to see where we're not doing what they recommend
@compwron , actually I am unable to replicate this issue as I am facing problem in setting up the development environment. After running rake db:create
I get a page-long error message along with Called from /home/snpd/.rvm/gems/ruby-2.5.5@doubleunion/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:240:in
load_dependency' fe_sendauth: no password supplied
Couldn't create database for {"adapter"=>"postgresql", "host"=>"localhost", "encoding"=>"unicode", "database"=>"doubleunion_test", "pool"=>5, "username"=>"postgres", "password"=>nil, "template"=>"template0"}
@snpd25 Hmm, that's not good. The error message seems to say that there is not a password set for the database. In the past that has not been required, which is why it's not in config/database.example.yml
I recommend setting a database password in your config/database.yml
and if that works please also update config/database.example.yml
What version of postgres do you have installed? It is possible that newer versions have new requirements. What operating system are you using, and how did you install postgres?
By running this command: sudo apt install postgresql postgresql-contrib
I get:
postgresql is already the newest version (10+190).
postgresql-contrib is already the newest version (10+190).
I am using UBUNTU 18.04 I didn't ever set a password for postgres
@snpd25 Are you still having this issue? I recommend setting a password
@anaulin Are these buttons still broken? They look ok to me in my local environment.
Yes, this is still broken in production (I just double-checked). Something about the asset paths is not quite the same in production, which is why this breaks there. Feels very low-priority, though.
I don't see this in the live website at the moment. So going to close. Feel free to reopen if someone is actually seeing this still
Agree, working on production for me. Thank you for closing!