arooo icon indicating copy to clipboard operation
arooo copied to clipboard

Fix sort up/down buttons

Open compwron opened this issue 5 years ago • 11 comments

This was broken by https://github.com/doubleunion/arooo/pull/333

Screen Shot 2019-06-16 at 4 40 08 PM

compwron avatar Jun 16 '19 23:06 compwron

maybe use this fork https://github.com/marlinpierce/jquery-datatables-rails

compwron avatar Jul 25 '19 00:07 compwron

@compwron , Can I work on this issue?

snpd25 avatar Oct 14 '19 12:10 snpd25

@snpd25 Yep! Thanks! :)

compwron avatar Oct 15 '19 04:10 compwron

@compwron , I would require a bit of guidance on how to fix this.

snpd25 avatar Oct 16 '19 13:10 snpd25

@snpd25 Are you having trouble

  1. replicating/seeing the issue
  2. deciding what the best solution would look like
  3. writing the code to implement the solution

Since async communication is slow, I'll try to answer all of them-

  1. To see the issue, visit production or staging (staging login info is in the readme)
  2. What should the fix be? Show any kind of indicator which implies to the user that the column is sortable- you get to decide! Anything better than the current weird boxes will be a win :)
  3. How to write the code- I would start by reading the https://github.com/rweng/jquery-datatables-rails readme and docs and seeing how the arooo code is using it, and trying to see where we're not doing what they recommend

compwron avatar Oct 17 '19 21:10 compwron

@compwron , actually I am unable to replicate this issue as I am facing problem in setting up the development environment. After running rake db:create I get a page-long error message along with Called from /home/snpd/.rvm/gems/ruby-2.5.5@doubleunion/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:240:in load_dependency' fe_sendauth: no password supplied Couldn't create database for {"adapter"=>"postgresql", "host"=>"localhost", "encoding"=>"unicode", "database"=>"doubleunion_test", "pool"=>5, "username"=>"postgres", "password"=>nil, "template"=>"template0"}

snpd25 avatar Oct 18 '19 17:10 snpd25

@snpd25 Hmm, that's not good. The error message seems to say that there is not a password set for the database. In the past that has not been required, which is why it's not in config/database.example.yml I recommend setting a database password in your config/database.yml and if that works please also update config/database.example.yml What version of postgres do you have installed? It is possible that newer versions have new requirements. What operating system are you using, and how did you install postgres?

compwron avatar Oct 18 '19 21:10 compwron

By running this command: sudo apt install postgresql postgresql-contrib I get:

postgresql is already the newest version (10+190).
postgresql-contrib is already the newest version (10+190).

I am using UBUNTU 18.04 I didn't ever set a password for postgres

snpd25 avatar Oct 20 '19 14:10 snpd25

@snpd25 Are you still having this issue? I recommend setting a password

compwron avatar Oct 25 '19 21:10 compwron

@anaulin Are these buttons still broken? They look ok to me in my local environment.

brittag avatar Feb 01 '21 18:02 brittag

Yes, this is still broken in production (I just double-checked). Something about the asset paths is not quite the same in production, which is why this breaks there. Feels very low-priority, though.

anaulin avatar Feb 02 '21 03:02 anaulin

I don't see this in the live website at the moment. So going to close. Feel free to reopen if someone is actually seeing this still

Aiyesha avatar Oct 10 '22 02:10 Aiyesha

Agree, working on production for me. Thank you for closing!

brittag avatar Oct 10 '22 14:10 brittag