react-native-track-player icon indicating copy to clipboard operation
react-native-track-player copied to clipboard

Feat: media3 & android auto

Open puckey opened this issue 1 year ago • 3 comments

A work in progress pull request building on subset of @lovegaoshi's work at https://github.com/lovegaoshi/react-native-track-player

  • without crossfading support
  • without widget code in the example app
  • adds backwards support for Capability.JumpBackward and Capability.JumpForward notification buttons.
  • todo: notification icon customization needs to be readded
  • todo: reconsider the custom notification buttons api
  • todo: Apple Carplay possibly using a shared api with Android Auto

puckey avatar Nov 18 '24 12:11 puckey

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Mar 05 '25 02:03 github-actions[bot]

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] avatar Mar 13 '25 02:03 github-actions[bot]

@puckey I was trying to pick up where you left off, and it looks like it runs fine after pulling in changes from main.

For those icons in media3, it sounds like you need to add drawable icons with specific names, so if that's true, we'd probably just need to remove that config and update the docs. I wasn't having much luck testing that out in the example folder, but I can keep digging into that, unless you have any ideas there. https://developer.android.com/reference/androidx/media3/session/DefaultMediaNotificationProvider#drawables

It seems like apple carplay should be in a separate pr, so these media3 updates can get merged in for now at least.

Is there anything else that still needs to be done on this?

Ken-Michalak avatar Apr 07 '25 18:04 Ken-Michalak

@lovegaoshi Could you please get this conflicts sorted. As migrating to androidx.media3 is required. I am still facing Unable to start service MusicService with null: android.app.ForegroundServiceStartNotAllowedException: Service.startForeground() not allowed due to mAllowStartForeground false issue in my app.

Hoping once the media3 is implemented this will fix the issue.

Amitchaudhary9648 avatar Jun 25 '25 07:06 Amitchaudhary9648

closing this in favor of https://github.com/doublesymmetry/react-native-track-player/pull/2478

jspizziri avatar Jun 25 '25 13:06 jspizziri