Crash with RN 76. New architecture support
Describe the Bug
App crashes with RN76 where new arch is enabled by default.
Steps To Reproduce Create new RN app and there we go...
Code To Reproduce
Just import TrackPlayer from 'react-native-track-player'; will cause the error
Environment Info:
Track player version:
"react-native-track-player": "^4.1.1"
System:
OS: Windows 11 10.0.22631
CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-12650H
Memory: 14.01 GB / 31.73 GB
npm:
version: 10.2.4
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
Android NDK: 23.1.7779620
Windows SDK: Not Found
IDEs:
Android Studio: AI-223.8836.35.2231.10406996
Visual Studio: Not Found
Languages:
Java:
version: 17.0.12
path: /c/Program Files/Common Files/Oracle/Java/javapath/javac
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 15.0.0
wanted: 15.0.0
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.1
wanted: 0.76.1
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
I am also facing issue in New architecture. Team please fix the issue and its very important for us.
@egorkhmelev @qmx @skahack
Describe the Bug App crashes with RN76 where new arch is enabled by default.
Steps To Reproduce Create new RN app and there we go...
Code To Reproduce Just
import TrackPlayer from 'react-native-track-player';will cause the errorEnvironment Info:
Track player version: "react-native-track-player": "^4.1.1" System: OS: Windows 11 10.0.22631 CPU: (16) x64 12th Gen Intel(R) Core(TM) i7-12650H Memory: 14.01 GB / 31.73 GB npm: version: 10.2.4 path: C:\Program Files\nodejs\npm.CMD Watchman: Not Found SDKs: Android SDK: Android NDK: 23.1.7779620 Windows SDK: Not Found IDEs: Android Studio: AI-223.8836.35.2231.10406996 Visual Studio: Not Found Languages: Java: version: 17.0.12 path: /c/Program Files/Common Files/Oracle/Java/javapath/javac Ruby: Not Found npmPackages: "@react-native-community/cli": installed: 15.0.0 wanted: 15.0.0 react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.76.1 wanted: 0.76.1 Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: Not found newArchEnabled: Not found
If you found any solution please ping me.
look at https://github.com/doublesymmetry/react-native-track-player/pull/2370
I'm also here because I'm facing this issue with 4.1.1 and RN 0.76.1 with New Arch enabled. I will be investigating and report any news.
Hi Same error here
Hi, I have the same error here w/ 4.1.1 and RN 0.76.1.
Obviously I need to disable the new architecture to make it work.
How can we help to make this library support the new arch?
How can we help to make this library support the new arch?
Try this PR At least app builds with it
https://github.com/doublesymmetry/react-native-track-player/pull/2290
Thanks i have tested and its works
How can we help to make this library support the new arch?
Try this PR At least app builds with it
#2290
Thanks, i have tested and its work.
#2290 yes this works on local but fails on eas build.
ERR_PNPM_PREPARE_PACKAGE Failed to prepare git-hosted package fetched from "https://codeload.github.com/doublesymmetry/react-native-track-player/tar.gz/9b8db7f": [email protected] yarn-install: yarn install Exit status 1 pnpm install --no-frozen-lockfile exited with non-zero code: 1
i dont think specifically ur error is this lib related. its more of a problem with ur package manager.
How can we help to make this library support the new arch?
Try this PR At least app builds with it
#2290
I tested it on my RN 0.76.3 env with new arch and seems to work, but for some reason when I play a message I don't see the state update of playing/stopping etc. I will keep checking if it is my code or something related to the patch.
Thanks
Facing same issue, after updating to rn76
One more detail, to make the events to work of RNTP, I had to patch the code as it is here:
https://github.com/doublesymmetry/react-native-track-player/pull/2370/files
yall should use https://github.com/doublesymmetry/react-native-track-player/pull/2395
On Wed, Nov 27, 2024, 8:43 AM smfunder @.***> wrote:
One more detail, to make the events to work of RNTP, I had to patch the code as it is here:
https://github.com/doublesymmetry/react-native-track-player/pull/2370/files
— Reply to this email directly, view it on GitHub https://github.com/doublesymmetry/react-native-track-player/issues/2389#issuecomment-2504334565, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZMOVVTRDPJ7OYTPYDOWJWT2CXZCRAVCNFSM6AAAAABRC6C7KKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBUGMZTINJWGU . You are receiving this because you commented.Message ID: @.*** com>
npm install --save react-native-track-player@3cd ios && pod updatecd ..- Rebuild the app again
npm install --save react-native-track-player@3cd ios && pod updatecd ..- Rebuild the app again
for android? what to do
npm install --save react-native-track-player@3cd ios && pod updatecd ..- Rebuild the app again
for android? what to do
Same thing without step 2 and 3.
In Android you can clean project before run:
Cd android ./gradlew clean
add this in your package.json for now
"react-native-track-player": "github:puckey/react-native-track-player#feature/update-react-native"
Thanks that was really helpful @itzyashh.
The PR is here: https://github.com/doublesymmetry/react-native-track-player/pull/2395 -- hope to see it merged soon 🤞
Hi, i found new bug, usePlaybackState(), useActiveTrack return not updated state, after add PR
Can confirm with @gh-pro
Hi, i confirm, all bug is closed in this pr
Any updates on getting this released? installing from the feature branch is working fine for me locally but it fails installing in eas so would be great if this was just in a supported npm release version
"react-native-track-player": "github:puckey/react-native-track-player#feature/update-react-native"
after adding this line. when I did -> npm install getting error.
Hi, I have the same error here w/ 4.1.1 and RN 0.76.1.
Obviously I need to disable the new architecture to make it work.
@oraylan is it working fine after disabled ?
Hi, I have the same error here w/ 4.1.1 and RN 0.76.1. Obviously I need to disable the new architecture to make it work.
@oraylan is it working fine after disabled ?
yes, so far no problem
Hi, I have the same error here w/ 4.1.1 and RN 0.76.1. Obviously I need to disable the new architecture to make it work.
@oraylan is it working fine after disabled ?
yes, so far no problem
Thank you so much brother, Last time I missed something. But Now it is working fine.
Installing from the related feature branch (github:puckey/react-native-track-player#feature/update-react-native) is now broken for me. is there any update on getting this merged? We haven't heard anything since the request was opened with a fix and it's been several months
I'm facing the same issue in RN 0.77. Any news on this bug?
