react-native-track-player icon indicating copy to clipboard operation
react-native-track-player copied to clipboard

Compact Players not respecting Compact Capabilities

Open jspizziri opened this issue 2 years ago • 7 comments

There are two issues with buttons in Android being displayed based on configured capabilities.

  1. https://github.com/doublesymmetry/react-native-track-player/issues/1701
  2. https://github.com/doublesymmetry/react-native-track-player/issues/1698
  3. https://discord.com/channels/567636850513018880/600714011318681610/1016786934888149082

Capabilities need to be re-evaluated and we should ensure that the proper controls show up corresponding to the options that are configured.

Note: we should be sure to test with both multi-track and single-track queues.

jspizziri avatar Sep 06 '22 15:09 jspizziri

I think the problem occurs when having a single track in the queue. If you have at least 2 track at all times, the remote skip button appears correctly.

ghiculescualexandru avatar Sep 07 '22 06:09 ghiculescualexandru

My app never has more than one track in the queue and always shows the previous track button. Can't get rid of it.

RamProg avatar Sep 07 '22 08:09 RamProg

Currently investigating this. Fixed a few unrelated bugs I found regarding which buttons appear by default. Will continue to work on it.

I think the problem occurs when having a single track in the queue. If you have at least 2 track at all times, the remote skip button appears correctly.

@ghiculescualexandru This is intended player behavior as it makes no sense for this button to exist when there is no other track to skip to.

My app never has more than one track in the queue and always shows the previous track button. Can't get rid of it.

@RamProg This is intended and will always show even if there is only a single track in the player, as skip to previous will then act as a "skip to beginning". As far as I'm aware the internal library we use doesn't allow that to change.

mpivchev avatar Sep 07 '22 18:09 mpivchev

Pleas see the discussion on https://github.com/doublesymmetry/react-native-track-player/issues/1708

jspizziri avatar Sep 08 '22 09:09 jspizziri

@RamProg This is intended and will always show even if there is only a single track in the player, as skip to previous will then act as a "skip to beginning". As far as I'm aware the internal library we use doesn't allow that to change.

Then we don't have a way of preventing that button from showing up?

This was possible on previous versions. So it's not a bug, but a limitation of the library?

RamProg avatar Sep 08 '22 09:09 RamProg

@RamProg yes, it's a limitation.

mpivchev avatar Sep 08 '22 15:09 mpivchev

@mpivchev kotlinaudio 1.2.3 contains this fix right?

jspizziri avatar Sep 14 '22 09:09 jspizziri

This is now fixed in main and will be released with 3.2 (and/or nightly, whichever comes first).

jspizziri avatar Sep 22 '22 17:09 jspizziri