packetnet icon indicating copy to clipboard operation
packetnet copied to clipboard

Published 20 hours ago ā€¢ verified publisher icon dotpcap

Appveyor

Open chmorgan opened this issue 4 years ago ā€¢ 15 comments

@PhyxionNL should we fix the appveyor build? Maybe we can just upgrade the visual studio version and it will be fixed? I can take a look.

chmorgan avatar Dec 09 '20 01:12 chmorgan

I think we can remove it, I do not see the need to run both AppVeyor and GitHub Actions.

PhyxionNL avatar Dec 09 '20 08:12 PhyxionNL

I had already removed this a while ago from README and repo, but I do not have access to 3rd party integrations so you'll need to make these changes.

PhyxionNL avatar Dec 09 '20 09:12 PhyxionNL

@chmorgan This still needs to be removed.

PhyxionNL avatar Jan 30 '21 09:01 PhyxionNL

I do like keeping more than one option open. We use several for sharppcap, GitHub workflows, Travis, circleci, azure, and Appveyor. They all offer slightly different oses and tools revs. If it becomes a big burden we can back away from appveyor, in the latest case it only took a minute to update from vs2017 to vs2019 for core 3.1 support. So Iā€™m inclined to say we should keep it for now.

On Sat, Jan 30, 2021 at 4:09 AM PhyxionNL [email protected] wrote:

@chmorgan https://github.com/chmorgan This still needs to be removed.

ā€” You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/chmorgan/packetnet/issues/116#issuecomment-770181620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJH4AGY6AAEPCHN6LG6DOTS4PEF5ANCNFSM4USYYGUQ .

chmorgan avatar Jan 30 '21 12:01 chmorgan

I do not think we need to keep it here, nothing is using it. AppVeyor is also a hell to configure, is currently not working, and causes PRs checks to go red.

PhyxionNL avatar Jan 30 '21 12:01 PhyxionNL

Appveyor removed, closing.

chmorgan avatar Apr 01 '21 01:04 chmorgan

@chmorgan Can you try again to remove AppVeyor? It's still here and it keeps failing šŸ¤”

  • Latest .NET SDK doesn't work.
  • Too Many Requests. Too Many Requests.

PhyxionNL avatar May 13 '22 18:05 PhyxionNL

hmm. let me look at that.

chmorgan avatar May 14 '22 00:05 chmorgan

How do you know that appveyor is failing? Are we getting emails from it? I see its still running somehow...

chmorgan avatar May 14 '22 00:05 chmorgan

alright, toggled off the packet net build setting. Let me know if you are still seeing failed builds from it.

chmorgan avatar May 14 '22 00:05 chmorgan

It's still running ā˜¹

PhyxionNL avatar May 14 '22 08:05 PhyxionNL

alright, toggled off the 'tests' setting too. I could just delete it entirely...

chmorgan avatar May 17 '22 01:05 chmorgan

Deleting would probably be better, as it's still going.

 continuous-integration/appveyor/branch Pending ā€” Waiting for AppVeyor build to complete

PhyxionNL avatar May 17 '22 08:05 PhyxionNL

Create an appveyor.yml with content See https://www.appveyor.com/docs/appveyor-yml/

build: off

kayoub5 avatar May 17 '22 09:05 kayoub5

I'd rather see it removed completely, GH Actions works fine, I don't see a need to run multiple CIs here, especially when AppVeyor never works reliably šŸ™‚

PhyxionNL avatar May 17 '22 09:05 PhyxionNL