Noah Watkins

Results 122 comments of Noah Watkins

> @andresaristizabal you can run the same command that `task lint:python` runs but point it at your tool. however, it sounds like something may not be quite correct with your...

Would it be possible to create a ducktape test for this tool?

> ducktape tests are in `tests/rptest/tests`. the basic idea would be to create a test that creates two `RedpandaService` instances and then pass the cluster configuration for the two clusters...

@andresaristizabal can you update this PR so we can merge it?

> Looks like I forgot to include that since it wasn't in the KIP, the KIP only talks about how the protocol was modified and Produce/Fetch support that field from...

> @dotnwat Ok taking a look at the source code now cool. I think this pr is looking pretty good. let's wait to see what you think after checking out...

is this PR sequenced after the flex protocol work or should it get another review now?

> I thought that Token bucket performs some separate logic. Util is something that performs a small specific task. Maybe I have the wrong understanding of separation there. Can you...

also, regarding multiplier. conclusion from conversation this morning with michal and rob and roman was that rate*multiplier was effectively the capacity of the bucket. action item is to change parameters...

> Doing this enforcement on the leader was considered however it would be impossible to return the estimated calculated throttle response time without heavily modifying the API, which is one...