SharpGrabber
SharpGrabber copied to clipboard
dotnettools
Don't download from xvideos
Could you provide more information about the scenario here? Also, please use the desktop app v4.1 since tests are passing for xvideos.
No problem. Get it from https://github.com/dotnettools/SharpGrabber/releases/tag/desktop4.1
Still not downloading. I paste the link from xvideos, click download, and I am offered to download ts file, but nothing is downloaded and this error appears.
This is weird. I found the video and I could easily download the video. Can you view the video in your browser?
Here's the URL I tried and worked: https://www.xvideos.com/video66511813/futa_fun_at_work_2_full_sounds
Are you a developer yourself? Can you debug and see what's causing this problem? Also try downloading another quality.
Did you try your browser? It could be because your IP or region is restricted or something like that.
Unfortunately I can't track down the problem with the information I have. I can't solve your problem today, and it won't be possible unless a diagnosis system is implemented in SharpGrabber.
try this before call the lib.
Thread.CurrentThread.CurrentCulture = System.Globalization.CultureInfo.InvariantCulture;
Were you having the same problem? If so, would you please submit a merge request?
@stewbuslo Don't think so. You'd need to debug and see where this error is coming from since I cannot reproduce this bug. What string is passed to what method which had led to the 'Input string was not in a correct format' error? If you tell me about the string and the exact file and line number that this happens I might be able to help or fix the bug.
I'm not sure if this is the same issue that I noticed recentliy. Some URI's seems to be not supported. For these uris, the Id has less than 8 digits. Could it possibly be due to a regex check whitch is not matching on the video-Id?
Edit: It is really hard to find an example URL with less than 8 digits. I found here a URL with 7 digits that can not be successfully validated by the grabber. "video1605676/blonde_teen_uspkirt_with_no_panties"
I suspect the problem from the thread creator is different though. In his example the id has 8 digits.
I'm not sure if this is the same issue that I noticed recentliy. Some URI's seems to be not supported. For these uris, the Id has less than 8 digits. Could it possibly be due to a regex check whitch is not matching on the video-Id?
Edit: It is really hard to find an example URL with less than 8 digits. I found here a URL with 7 digits that can not be successfully validated by the grabber. "video1605676/blonde_teen_uspkirt_with_no_panties"
I suspect the problem from the thread creator is different though. In his example the id has 8 digits.
Have you tried debugging it?
The error message is comming from the url validation of the sharp grabber library. I'm currently using my own implementation of the User Interface and need to download the Grabber Desktop Project first for debugging. I can tell you tomorrow where the problem is exactly located.
By the way, I'm using the sharp grabber project to learn how you can download videostreams, Thank you very much for your Work :)
My own prototype helps me to test my learning progress. It is currently only support xvideos links. https://github.com/hswlab/dist-pronothek
My goal is to implement a downloader for my favorite Websites, where I couldn't find a working Video Downloader yet. :)
Oh man, I'm very sorry. I debugged this URL now with your desktop application but I could't find any problem. It works just fine. This seems to be a problem with my own implementation. I added some additional detection logic to detect also urls directly from the preview images on the profile sites. This additional code makes usually an url transformation in a format that sharp grabber can handle, but in my case the transformation was going wrong and passed a bad url to sharp grabber. So in this case I have to fix it myself, sorry^^'
I also remembered that from time to time there is an error with the following line. SharpGrabber.Adult\XnxxGrabber.cs line 58
// grab resources var hls = paramMap["VideoHLS"] as string;
This happens only sometimes for a certain period of time, then suddenly it works again. Apparently the hls info is missing when parsing the page and is therefore missing in the array. Could this probably be the problem of the thread creator? That the hls url was just not available in the html for grabbing it?
I am not sure why this happens. Maybe xvideos is doing maintenance on the site, or something similar.
Not sure really and currently I don't have enough free time to dig into it. It'd be nice if you could find a pattern and debug it :) I suggest writing a quick and dirty logger to log the source HTML file so you can examine what was responded by the server.
I already have a suspicion why this happens. After all, I made so many requests for testing during development, that hd videos were probably blocked for me for a while. Google does it with their API's in a similar way :-)
Well, if this problem should occur again, I will make a text copy of the response. Then there would be at least something to test with :)
I added an example of the content result in the attachment. This causes the following "Grab error".
NO HLS RESULT.txt
It seems that the paramMap has no such key "VideoHLS" in
\SharpGrabber.Adult\XnxxGrabber.cs
func: InternalGrabAsync (row58)