dotnetthailand.github.io icon indicating copy to clipboard operation
dotnetthailand.github.io copied to clipboard

Support Tablet Device

Open mildronize opened this issue 4 years ago • 8 comments

Website should be supported Tablet device size.

Problems

Problem on width 800px-1100px

  • The menu bar display multiple lines,
  • Sidebar width is too wider for tablet.

here is the screenshot on device width about 800px

image

and here is the screenshot on device width about 1100px

image

Problem on width about 767px (on tablet portrait);

  • Too wider width for sidebar

here is the screenshot on device width about 767px

image

Possible Solution

  • Adjust font size and sidebar width on targeted screen width range.

mildronize avatar Aug 08 '21 08:08 mildronize

Could you please give a screenshot of issue on a tablet device? Thanks.

aaronamm avatar Aug 15 '21 17:08 aaronamm

Yes @aaronamm, I've updated the topic

mildronize avatar Aug 17 '21 16:08 mildronize

@mildronize Thank you so much.

aaronamm avatar Aug 18 '21 04:08 aaronamm

I want to help on this PR. Please, give me more specific actual result. 😁 🙏

Updated:

I understand on 800px-1100px case. But, i'm not sure for 767px case. Do you want to show sidebar ? Because you can use sidebar menu from hamburger button on the top-right.

runyasak avatar Oct 26 '21 12:10 runyasak

@runyasak Thank you so much for your intention to help this issue. The idea of 767px case is when user open sidebar, the sidebar width should be equal to desktop size, not 100% width.

The expected solution of 767px case. When user open the menu, the sidebar width should be same width desktop size.

image

However, this case may change behavior of sidebar in JS or CSS, feel free to help us.

Again, Thank you very much,

mildronize avatar Oct 27 '21 01:10 mildronize

Hi, @mildronize.

I have fixed for 800px - 1100px case, please checkout this #181 .

However, there have a bug for sidebar on 767px, you can scroll down to see content and that would be hard work to do. image

runyasak avatar Oct 28 '21 17:10 runyasak

@runyasak Thank you very much. I've merged.

mildronize avatar Oct 29 '21 14:10 mildronize

Yep for the case sidebar on 767px, it'll take some time to do. That PR #181 Look great that solved the problem. @runyasak

mildronize avatar Oct 29 '21 14:10 mildronize