Magicodes.IE icon indicating copy to clipboard operation
Magicodes.IE copied to clipboard

IE PR standard specification discussion(IE PR规范讨论)

Open hueifeng opened this issue 4 years ago • 2 comments

目前的代码提交情况,导致我们在一些紧急情况下发版本或者进行修改代码无法顺利发版. 在一些功能未完善的功能或者错误情况下严重的也影响我们

The current code submission situation affects the issue of the version or the modification of the code in some emergency situations. Some imperfect functions or errors seriously affect us

hueifeng avatar Apr 20 '20 04:04 hueifeng

下个大版本开始,执行严格的git分支流,同时PR仅能合并到Develop分支。

xin-lai avatar Apr 25 '20 06:04 xin-lai

PR基本要求补充如下:

  1. 仅允许PR到Develop分支;

  2. 需编写单元测试;

  3. 提交注释中需要说明更改内容;

  4. 代码需遵循C#代码规范;

  5. 代码注释需提供中英注释;

  6. 必要时需编写文档。

The basic requirements of PR:

  1. Only allow PR to Develop branch;

  2. Need to write unit tests;

  3. The submitted comments need to explain the changes;

  4. The code must follow the C# code specification;

  5. Code comments need to provide Chinese and English comments;

  6. Documents need to be written if necessary.

xin-lai avatar Apr 25 '20 06:04 xin-lai