wpf icon indicating copy to clipboard operation
wpf copied to clipboard

Restore pre-NET8 automation behavior in the ItemsControl

Open jimm98y opened this issue 7 months ago • 4 comments

Fixes #8679

Description

Pull request #6862 fixed an issue with grouped ItemsControl not exposing grouped items to the automation, but as a side-effect it broke automation in ItemsControl without grouping. This pull request keeps the fix for grouped ItemsControl and restores the original behavior for non-grouped ItemsControl.

Customer Impact

Automation is broken for non-grouped ItemsControl.

Regression

Yes. This is broken since NET8, in NET7 and NET6 this was working correctly.

Testing

Sample app from #6861 on NET6 was updated with XAML from sample app in #8679 and the custom ItemsControl code was patched with the proposed fix test.zip. Both grouped and ungrouped ItemsControls are working.

Risk

Like the original change that has caused the issue in NET8 automation, even this pull request can have some unforeseen consequences in scenarios not covered by the current test cases.

Microsoft Reviewers: Open in CodeFlow

jimm98y avatar Jan 20 '24 16:01 jimm98y