winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Removing extra cases in GetPropertyValue from from children classes.

Open NikitaSemenovAkvelon opened this issue 2 years ago • 2 comments

Fixes #6236

Proposed changes

  • Moved returning values of the virtual properties to the base class.
  • Ordered switch cases in AccessibleObject.GetPropertyValue alphabetically.
  • Removed extra RecnatgleBounds overridings.
  • Used switch expression instead of if blocks.

Customer Impact

  • It's a technical refactoring.

Regression?

  • No

Risk

  • Minimal

Test methodology

  • Unit tests

Test environment(s)

  • 7.0.100-preview.5.22307.18
Microsoft Reviewers: Open in CodeFlow

NikitaSemenovAkvelon avatar Aug 04 '22 11:08 NikitaSemenovAkvelon

Adding no-merge label to take this in NET8 because this change is a refactoring and thus does not meet the NET7 bug bar.

Tanya-Solyanik avatar Aug 04 '22 17:08 Tanya-Solyanik

Please send privates to CTIs to test this change, but let them know that this is a low priority task because it will go into NET8.

Tanya-Solyanik avatar Aug 04 '22 17:08 Tanya-Solyanik

Tested this PR with changed controls in Accessibility tools, no new issue was found.

Olina-Zhang avatar Aug 16 '22 10:08 Olina-Zhang