Remove dependency on RemoteExecutor in tests

[willibrandon]

Fixes #4500

Proposed changes

• Remove dependency on RemoteExecutor in tests as it has been proven to be unstable.
• Migrate tests that change global state and that rely on RemoteExecutor to the UIIntegration test project.

Customer Impact

• Test methods should not be skipped.

Regression?

• No

Risk

• Minimal

Test methodology

• Ran unit and integration tests and observed for any signs of destabilisation.

Test environment(s)

• 7.0.100-preview.6.22352.1

Microsoft Reviewers: Open in CodeFlow

[willibrandon]

Since tests have been updated to run with visual styles on by default, are these 2 tests worth keeping, or should they be modified?

https://github.com/dotnet/winforms/blob/55b296932065022705a6af218ab04a9d90049a28/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ApplicationTests.cs#L79

And the first two assertions in this test are no longer true.

https://github.com/dotnet/winforms/blob/55b296932065022705a6af218ab04a9d90049a28/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ApplicationTests.cs#L90

[RussKie]

Trying to page back - is there something that you're waiting for me here?

[willibrandon]

No. I've been adjusting to a new schedule, pardon me.

I'm close to having the changes ready and will make it a priority now.

[RussKie]

@willibrandon I got a notification of a comment but I can't seem to locate it, sorry.... It looks like we have a lot of ongoing discussions, and I find it hard to keep track of all of them. Do you think you could rebase and address any remaining pending comments?

[willibrandon]

@RussKie - Someone should take the delete button away from me. Sometimes I'm second guessing myself so much that it is too tempting not to click it. With that said, I have been made acutely aware of how confusing this can be and that I should treat this like email. I will do my best to never click the delete button ever again.

[RussKie]

Haha, all good. I do post and then delete sometimes, though generally I try to post another message instead.

[willibrandon]

I have some feedback left to address on this, and working towards that now.

[merriemcgaw]

@willibrandon sorry this fell through the cracks! I'm closing this now but if you're willing to pick it back up just holler and we can re-open it for you.

[willibrandon]

My apologies. Sometimes I bite off more than I can chew 😩. These tests can be very finicky, and time-consuming.

With that said, I don't want to give up on this, especially if #4500 is still an issue. I just might not be the best person to tackle this one yet. I'll see if I can get back to it, and if so, I will holler.