winforms icon indicating copy to clipboard operation
winforms copied to clipboard

[release/3.1] Update dependencies from dotnet/arcade

Open dotnet-maestro[bot] opened this issue 2 years ago • 8 comments

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: a2a5ea62-d9bf-419c-0c86-08d7315b512a
  • Build: 20221012.2
  • Date Produced: October 12, 2022 5:09:37 PM UTC
  • Commit: 869528d3af327eb6de19b414631280734dfe76e6
  • Branch: refs/heads/release/3.x
  • Updates to .NET SDKs:
    • Updates sdk.version to 3.1.424
    • Updates tools.dotnet to 3.1.424
Microsoft Reviewers: Open in CodeFlow

dotnet-maestro[bot] avatar Apr 13 '22 15:04 dotnet-maestro[bot]

/azp run

Tanya-Solyanik avatar Apr 15 '22 02:04 Tanya-Solyanik

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 15 '22 02:04 azure-pipelines[bot]

it seems Serialization of the Font is prevented at runtime using binary formatter. Need to understand the change. @mmitche as FYI

dreddy-work avatar Apr 19 '22 00:04 dreddy-work

@JeremyKuhne , do you know anything changed in runtime regarding Font serialization?

dreddy-work avatar Apr 20 '22 17:04 dreddy-work

@jeffhandley did we block BinaryFormatter in the runtime?

JeremyKuhne avatar Apr 20 '22 21:04 JeremyKuhne

@jeffhandley did we block BinaryFormatter in the runtime?

I'm not sure if/what we would have done in 3.1 branches around BinaryFormatter. I'll have to tag @GrabYourPitchforks to investigate and weigh in.

jeffhandley avatar Apr 21 '22 05:04 jeffhandley

There were no changes to BinaryFormatter or Font in 3.1 servicing. The release/3.1 tree still shows Font as serializable:

https://github.com/dotnet/corefx/blob/b375800a161c9f51e3c45b62dbea078725b23d5b/src/System.Drawing.Common/src/System/Drawing/Font.cs#L14-L23

Some random uncollected thoughts:

  • Maybe the test infrastructure is inspecting the ref assemblies rather than the implementation assemblies? The ref assemblies are not marked [Serializable] because they don't need to be.
  • Maybe two different versions of [Serializable] are being brought in, and the "wrong" one is being applied to the Font type?
  • Maybe the .dll is just corrupted?
  • Maybe reflection somehow broke? The VM special-cases [Serializable].

Edit: I also pulled the 3.1.418 SDK from https://dotnet.microsoft.com/en-us/download/dotnet/3.1 and validated that Font (in System.Drawing.Common.dll) does indeed have [Serializable] applied.

GrabYourPitchforks avatar Apr 25 '22 23:04 GrabYourPitchforks

@RussKie , do you have sometime to debug these tests to explore further here?

dreddy-work avatar Apr 26 '22 21:04 dreddy-work

@mmitche , i am closing this given we are not going to make anything in 3.1. Please let me know if you think otherwise.

dreddy-work avatar Jan 19 '23 19:01 dreddy-work

@dreddy-work Correct. 3.1 branches, btw, are supposed to be tagged and deleted. Please see the mail from @wtgodbe to tactics last week.

mmitche avatar Jan 19 '23 19:01 mmitche