winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Cleanup AvoidPassingTaskWithoutCancellationTokenAnalyzer

Open Youssef1313 opened this issue 7 months ago • 6 comments

Fixes #

Proposed changes

  • Implement analyzer using IOperation instead of syntax.
  • Moving the implementation to language agnostic layer now that we don't need language syntax.

Customer Impact

Regression?

  • Yes / No

Risk

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Youssef1313 avatar Jun 07 '25 03:06 Youssef1313

@KlausLoeffelmann Assuming this goes green now, can you review please? Thanks!

Youssef1313 avatar Jun 08 '25 10:06 Youssef1313

Codecov Report

:x: Patch coverage is 90.16393% with 6 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 76.59450%. Comparing base (f2060df) to head (a8c2683). :warning: Report is 237 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #13566         +/-   ##
===================================================
+ Coverage   75.42791%   76.59450%   +1.16658%     
===================================================
  Files           3230        3230                 
  Lines         639213      639213                 
  Branches       47303       47300          -3     
===================================================
+ Hits          482145      489602       +7457     
+ Misses        148044      146041       -2003     
+ Partials        9024        3570       -5454     
Flag Coverage Δ
Debug 76.59450% <90.16393%> (+1.16658%) :arrow_up:
integration 18.79856% <ø> (?)
production 51.00127% <90.16393%> (+2.60155%) :arrow_up:
test 97.40114% <ø> (ø)
unit 48.37494% <90.16393%> (-0.02477%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 10 '25 07:06 codecov[bot]

@KlausLoeffelmann This is green now.

Youssef1313 avatar Jun 10 '25 07:06 Youssef1313

@KlausLoeffelmann Can you review this please?

Youssef1313 avatar Jun 12 '25 11:06 Youssef1313

Ping @KlausLoeffelmann for review

Youssef1313 avatar Jun 20 '25 06:06 Youssef1313

Ping @KlausLoeffelmann

Youssef1313 avatar Jun 26 '25 07:06 Youssef1313

Closing stale PR.

Youssef1313 avatar Sep 24 '25 07:09 Youssef1313