winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Unify DesignSurface and TestConsole into DemoConsole

Open ricardobossan opened this issue 7 months ago • 4 comments

Fixes #13388

Proposed changes

  • Renamed files in DesignSurfaceExt to match the updated class names from PR #13433
  • Moved all code files from DesignSurfaceExt into the DemoConsole project directory
  • Integrated all relevant configuration from DesignSurfaceExt.csproj into DemoConsole.csproj
  • Deleted DesignSurfaceExt.csproj
  • Merged the contents of Directory.Build.props into DemoConsole.csproj to consolidate all settings in one place
  • Removed the now redundant Directory.Build.props file
  • Relocated the DemoConsole folder up one level to align with other integration test projects
  • Deleted the now empty DesignSurfaceExt folder

Customer Impact

  • None

Risk

  • Minimal

Test methodology

  • Manual

Test environment(s)

  • 10.0.100-preview.3.25201.16
Microsoft Reviewers: Open in CodeFlow

ricardobossan avatar May 09 '25 21:05 ricardobossan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.20921%. Comparing base (16058a3) to head (5dc54c8). Report is 2 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (16058a3) and HEAD (5dc54c8). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (16058a3) HEAD (5dc54c8)
Debug 3 2
test 1 0
Additional details and impacted files
@@                 Coverage Diff                  @@
##                main      #13437          +/-   ##
====================================================
- Coverage   76.69388%   51.20921%   -25.48467%     
====================================================
  Files           3255        2063        -1192     
  Lines         641604      287751      -353853     
  Branches       47491       42056        -5435     
====================================================
- Hits          492071      147355      -344716     
+ Misses        145877      137510        -8367     
+ Partials        3656        2886         -770     
Flag Coverage Δ
Debug 51.20921% <ø> (-25.48467%) :arrow_down:
integration 18.99141% <ø> (-0.00350%) :arrow_down:
production 51.20921% <ø> (-0.00348%) :arrow_down:
test ?
unit 48.58854% <ø> (+0.00035%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 09 '25 21:05 codecov[bot]

Hey @LeafShi1, @ricardobossan

what are we doing with this one?

It probably would need to be rebased and the requested has not been applied yet (but I only looked so briefly).

Do y'all want to keep this?

KlausLoeffelmann avatar Jun 09 '25 16:06 KlausLoeffelmann

Hi @KlausLoeffelmann,

Tanya's goal was to unify the DemoConsole and DesignSurface projects. This was structured as a two-step process across two PRs:

  1. Unify namespace and class names across all files (PR #13433, already merged)
  2. Rename files and folders (this PR)

Since the first step is already complete, renaming the files and folders is the natural continuation.

I've rebased the branch and resolved the merge conflicts. They were straightforward.

After the rebase, I tested the DemoConsole (now fully unified with DesignSurfaceExt) on both target frameworks (.NET 10 and net481). Everything appears to be working as expected.

I’d recommend moving forward with this PR.

@LeafShi1, what do you think?

ricardobossan avatar Jun 09 '25 22:06 ricardobossan

@LeafShi1, what do you think?

It will be fine to keep this. Please resolve the conflict.

LeafShi1 avatar Jun 11 '25 08:06 LeafShi1