Cannot enter characters when adding ToolStripMenuItem1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application
.NET version
main branch of WinForms repo
Did it work in .NET Framework?
Yes
Did it work in any of the earlier releases of .NET Core or .NET 5+?
Yes, this is a regression issue. Not repro on .NET 9.0 from Release/9.0 branch of WinForms repo.
https://github.com/user-attachments/assets/11a56acc-3a27-43d0-adeb-20824cb2bb96
Issue description
Actual result: Cannot enter characters when adding ToolStripMenuItem1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application.
https://github.com/user-attachments/assets/1e6fe900-449b-43bd-bfd1-e0c714f73a84
Expected result: Characters can be entered when adding ToolStripMenuItem1 and then adding ToolStripMenuItem2 after pressing enter in DemoConsole application.
https://github.com/user-attachments/assets/42c4d5a2-b530-4d27-a466-7db5e687c202
Steps to reproduce
Test sample: DemoConsole bases on main branch in Winforms repo.
More info:
- This issue rerpo in ContextMenuStrip/MenuStrip/ToolStrip/BindingNavigator control in DemoConsole application.
@LeafShi1 can your team look into this one?
The issue is caused by commit #13034:
fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1.
Still need to find a solution that resolves both this regression and the original problem from #12916 without reintroducing either.
git bisect log
git bisect start status: waiting for both good and bad commits good: [78c7bb89560a456a0f56aa05dc8b5ba222edf83f] System.Data.SqlClient - use version recommended by the SQL team, I couldn't find v5, not sure if it exists, we are not referencing this package right ow, so this is not a problem. Nuget.Packaging - use version that does not pull in vulnerable System.Formats.Asn1 (v8.0,0) Change in the VB test project - this assembly is not references directly, transitive versions can be resolved from the central packaging git bisect good 78c7bb89560a456a0f56aa05dc8b5ba222edf83f status: waiting for bad commit, 1 good commit known bad: [9092b067aaec1122e8aa0163951cbe5862431125] [main] Update dependencies from dotnet/runtime (#13363) git bisect bad 9092b067aaec1122e8aa0163951cbe5862431125 bad: [1a430821e2c4696a5bd8f79db746aeb3ffb1f608] Ensure that System.Drawing facade assembly is built before the tests that consume it are. (#13119) git bisect bad 1a430821e2c4696a5bd8f79db746aeb3ffb1f608 bad: [1a430821e2c4696a5bd8f79db746aeb3ffb1f608] Ensure that System.Drawing facade assembly is built before the tests that consume it are. (#13119) git bisect bad 1a430821e2c4696a5bd8f79db746aeb3ffb1f608 good: [707898d6ce7eea814da61e2ec05bde666d27b85b] [main] Update dependencies from dotnet/arcade (#13032) git bisect good 707898d6ce7eea814da61e2ec05bde666d27b85b bad: [316a77b46ba75f2a68aef1abcf4addb47e75bc79] Remove extra dot at the end of resource string (#13091) git bisect bad 316a77b46ba75f2a68aef1abcf4addb47e75bc79 bad: [5e8147d352c945eea0c9135faf0996d96993f8b9] Resizes
DemoConsoleproject'sMainFormfor convenience and to make everything visible in the surface designer (#13050) git bisect bad 5e8147d352c945eea0c9135faf0996d96993f8b9 bad: [6e112b86c1b98a44f4473d45a7a7ec0d90354a7c] fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1 (#13034) git bisect bad 6e112b86c1b98a44f4473d45a7a7ec0d90354a7c good: [e9f1c43f83a393d0c7d3e0af70c26f589c5570f9] Enable nullability in DesignerActionMethodItem (#12676) git bisect good e9f1c43f83a393d0c7d3e0af70c26f589c5570f9 good: [e65c611ef4456c8a0d8250a10afcc27466f7cd23] [main] Update dependencies from dotnet/arcade (#13038) git bisect good e65c611ef4456c8a0d8250a10afcc27466f7cd23 good: [2dc1fbe6e65e068347aeb62ea558637ad35e647f] Add code coverage for ControlCodeDomSerializer (#13011) git bisect good 2dc1fbe6e65e068347aeb62ea558637ad35e647f first bad commit: [6e112b86c1b98a44f4473d45a7a7ec0d90354a7c] fix #12916 Cannot use down to expand ToolStripDropDownButton in toolStrip2 after using right/Left to collapse ToolStripDropDownButton in toolStrip1 (#13034)
@Tanya-Solyanik I’ve confirmed this issue does not reproduce at design-time in Visual Studio.
I tested it by building the runtime at the commit from PR #13034 and replacing my local installation of Microsoft.WindowsDesktop.App with the modified DLLs. Then I created a new WinForms project targeting the latest SDK and verified the behavior in the designer:
The issue only happens in the DemoConsole, not in actual design-time.
Should we consider this a won't fix, or would we want to address it specifically for DemoConsole?