winforms icon indicating copy to clipboard operation
winforms copied to clipboard

fix #12365 [Accessibility] The text "Document does not contain any pages" in printPreviewControl has low color contrast

Open Epica3055 opened this issue 1 year ago • 1 comments

Fixes #12365

Proposed changes

  • Change the text color to black

Regression?

  • No

Risk

  • low

Screenshots

Before

Image

After

image

Test methodology

  • manual
Microsoft Reviewers: Open in CodeFlow

Epica3055 avatar Oct 22 '24 09:10 Epica3055

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.58920%. Comparing base (e8a65f9) to head (f6f7e29). Report is 40 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12368         +/-   ##
===================================================
- Coverage   75.64857%   75.58920%   -0.05938%     
===================================================
  Files           3120        3135         +15     
  Lines         635396      635989        +593     
  Branches       46933       47025         +92     
===================================================
+ Hits          480668      480739         +71     
- Misses        151270      151795        +525     
+ Partials        3458        3455          -3     
Flag Coverage Δ
Debug 75.58920% <0.00000%> (-0.05938%) :arrow_down:
integration 18.26808% <0.00000%> (-0.01432%) :arrow_down:
production 49.12374% <0.00000%> (-0.08025%) :arrow_down:
test 97.02706% <ø> (+0.00013%) :arrow_up:
unit 46.09268% <0.00000%> (-0.05613%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 22 '24 10:10 codecov[bot]

Loogs good, but could you please get this change tested by @Olina-Zhang's team?

Tanya-Solyanik avatar Oct 26 '24 02:10 Tanya-Solyanik

1 non-regression issue was found in HC mode, and a new issue 12401 has been filed to track it.

LeafShi1 avatar Oct 31 '24 01:10 LeafShi1

@Epica3055 - please prepare this one for servicing

Tanya-Solyanik avatar Nov 06 '24 00:11 Tanya-Solyanik

/backport to release/9.0

Epica3055 avatar Nov 06 '24 02:11 Epica3055

Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/11695857589

github-actions[bot] avatar Nov 06 '24 02:11 github-actions[bot]