winforms icon indicating copy to clipboard operation
winforms copied to clipboard

fix #12358 [HDPI] The "document" text in the “Generating Previews” dialog is truncated at >200% DPI

Open Epica3055 opened this issue 1 year ago • 2 comments

Fixes #12358

Proposed changes

  • Make the indicator's width wider.

Regression?

  • Yes

Risk

  • low

Screenshots

Before

Image

After

image image image

Test methodology

  • manual
Microsoft Reviewers: Open in CodeFlow

Epica3055 avatar Oct 22 '24 02:10 Epica3055

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 76.02611%. Comparing base (e8a65f9) to head (3e2afb2). Report is 185 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12363         +/-   ##
===================================================
+ Coverage   75.64857%   76.02611%   +0.37753%     
===================================================
  Files           3120        3162         +42     
  Lines         635396      639258       +3862     
  Branches       46933       47179        +246     
===================================================
+ Hits          480668      486003       +5335     
+ Misses        151270      149752       -1518     
- Partials        3458        3503         +45     
Flag Coverage Δ
Debug 76.02611% <0.00000%> (+0.37753%) :arrow_up:
integration 18.15388% <0.00000%> (-0.12852%) :arrow_down:
production 49.77987% <0.00000%> (+0.57588%) :arrow_up:
test 97.02820% <ø> (+0.00127%) :arrow_up:
unit 46.97469% <0.00000%> (+0.82588%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 22 '24 02:10 codecov[bot]

Changes seem fine to me, but could we do testing on this to make sure there are no other regressions

lonitra avatar Oct 22 '24 21:10 lonitra

Tested private dlls for this PR, here is the result.

For 11456, issue3(An error was detected by using Accessibility Insight tool for the "Page 1 of document" pattern) has been fixed. Currently only Narrator can't announce “Generating Previews”, NVDA and JAWS can announce it correctly, and isDialog and AccessibleName properties are correct.

For 12358, three regression HDPI issues (compared with the behaviors in .NET 8.0) still repro. See details in the team's channel.

Philip-Wang01 avatar Oct 31 '24 09:10 Philip-Wang01

@Epica3055 - what accessible properties differ between the Label and the LinkLabel? Let's review them and any important property, like ControlType, can be fixed in a custom accessible object.

Tanya-Solyanik avatar Nov 04 '24 19:11 Tanya-Solyanik

@Tanya-Solyanik I created a demo project. image

Epica3055 avatar Nov 05 '24 02:11 Epica3055

Name and Automation Id properties are in your control, it will be set here - internal Label _messageLabel; The problem is the child heirarchy. Could you please try to get rid of it, start by not having any links, then if that does not work, implement a custom accessible object that overrides the Navigation methods - FragmentNavigate, GetChild, GetChildCount

Tanya-Solyanik avatar Nov 05 '24 18:11 Tanya-Solyanik

Tested private dlls for this PR, here is the result.

For https://github.com/dotnet/winforms/issues/11456, One behavior needs to be confirmed. Narrator still can't announce “Generating Previews”, NVDA announce it correctly, and isDialog and AccessibleName properties are correct.

For https://github.com/dotnet/winforms/issues/12358, all HDPI issues have been fixed and there are no new regressions.

Philip-Wang01 avatar Nov 12 '24 10:11 Philip-Wang01

Please investigate how to override AccessibleRole and ControlType for the new object

Tanya-Solyanik avatar Nov 13 '24 01:11 Tanya-Solyanik

@Tanya-Solyanik

When we focus on LinkLabel using AccessibleTool, we actually focus on Link. So we need to change Link AccessibleRole , please review latest commit in this pr to see if that's acceptable.

Epica3055 avatar Nov 20 '24 01:11 Epica3055

@Tanya-Solyanik do you think the three issues described in test report by test team acceptable?

Epica3055 avatar Dec 10 '24 06:12 Epica3055