winforms icon indicating copy to clipboard operation
winforms copied to clipboard

fix issue #5961 Row header border line of the DataGridView control has very low luminosity contrast ratio

Open Epica3055 opened this issue 1 year ago • 3 comments

Fixes #5961

Proposed changes

  • use a different color when RightToLeft is set to Yes

Regression?

  • Yes

Screenshots

Before

image

After

image

When color applied

image

When RightToLeft is set to No

image

Test methodology

  • manually

Test environment(s)

  • 10.0.0-alpha.1.24455.17
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

Epica3055 avatar Oct 09 '24 09:10 Epica3055

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.46505%. Comparing base (49b0091) to head (830bb8f). Report is 94 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12293         +/-   ##
===================================================
+ Coverage   75.43409%   75.46505%   +0.03096%     
===================================================
  Files           3103        3106          +3     
  Lines         634314      634446        +132     
  Branches       46876       46888         +12     
===================================================
+ Hits          478489      478785        +296     
+ Misses        152401      152228        -173     
- Partials        3424        3433          +9     
Flag Coverage Δ
Debug 75.46505% <50.00000%> (+0.03096%) :arrow_up:
integration 17.97985% <0.00000%> (-0.00418%) :arrow_down:
production 48.87627% <50.00000%> (+0.05753%) :arrow_up:
test 97.02609% <ø> (+0.00113%) :arrow_up:
unit 45.91040% <50.00000%> (+0.06000%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 09 '24 09:10 codecov[bot]

@Epica3055 - please get this tested

Tanya-Solyanik avatar Oct 09 '24 18:10 Tanya-Solyanik

@Epica3055 - please address issues found by Zheng.

Tanya-Solyanik avatar Oct 15 '24 19:10 Tanya-Solyanik