[Tracking] Current VB work (Refactoring and adding tests)

[KlausLoeffelmann]

[Draft]

This will be the tracking issues for all the ongoing VB work that we want to accomplish in the .NET 10-time frame.

• [ ] https://github.com/dotnet/winforms/pull/12226 (Refactoring out large code into 7 logical partial classes/code files)
• [ ] https://github.com/dotnet/winforms/pull/12221 (Adding tests for VB App Framework Download tests)
• [ ] https://github.com/dotnet/winforms/pull/12227 (Adding tests for VB App Framework Clipboard class)

[KlausLoeffelmann]

@paul1956:

Could you please list your suggested PR order as I started it in an answer to this comment? I will then take a look as soon as I get to it and paste it into this tracking issue. Let's then tackle this step by step.

Please do not create another PR, before we have this sorted out! 😸

[paul1956]

@KlausLoeffelmann @Tanya-Solyanik Most of the original issues have been Merged, below is what is left with details. The bottom 4 PR's are DRAFT as they depend on the previous PR's.

#12507 Reennable test broken in Merge and fix developer usability issues A test is missing Fact Two Forms in VB Repo (ProgressDialog and VBInputBox) cause Designer to error when double clicked. This PR adds <DesignerCategory("Default")> to avoid opening Designer. There are a few comments missing a space between quote and text.

#12486 Code Coverage for DownloadFile Review 1St] Adds a download server, so tests have no external dependencies. Adds the tests for DownloadFile when used against the existing code there is 100% coverage. This will allow confidence that the #12489 will behave identically.

#12489 Fix issue#9807 2nd DRAFT Removes dependency on WebClient for downloads Adds Friend DownloadFileAsync, making public requires API Review

#12118 Shorten long lines in VB REVIEW (3rd) AFTER #12489 DRAFT Purely cleanup no logic changes. This shortens line over 120-130 characters in VB

#12139 Shorten long inline comments REVIEW (4th) DRAFT Purely C# cleanup no logic changes

#12148 Improve xml comments review 5th DRAFT

[KlausLoeffelmann]

OK, that helps. I'll go through those soon, but I think the first one will be the one I have in the list already "to get ramped up" so to say. Nothing for you to do, right now, would like to ask for patience. I'll keep you posted.

[lonitra]

Apologies. Looks like merging PR automatically closed this. I've reopened.

[adegeo]

Here are some things I noticed about VB while working on the Winforms Migration article:

• Creating a project in VS, the HighDpiMode is missing in Application.myapp until you set it via project properties.
• Changing Application Framework > Windows Visual Style in project properties doesn't apply on next compile. I have run the project twice to get it working.
• In Solution Explorer, double-clicking on My Project opens the project settings page, but fails to navigate to the Application Framework section.