winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Add WinForms Analyzer and CodeFixes Infrastructure for C# and Visual Basic

Open KlausLoeffelmann opened this issue 1 year ago • 2 comments

This PR introduces/extends the WinForms Analyzer infrastructure for C# and Visual Basic. We will be introducing for .NET 9 a first set of Analyzers and Code Fixes, specifically for WinForms applications. The Analyzers will help developers to identify common issues in their WinForms applications and the Code Fixes will help to automatically fix these issues.

The PR includes the following changes:

  • Refactor existing Analyzers in preparation to add VB Projects both for Analyzers and Code Fixes.
  • Introduce Analyzers/CodeFixes for missing CodeDOM serialization configuration both for C# and VB.
  • Bump up Roslyn/Analyzer NuGet package versions.
  • Fix formatting in resource files and inconsistencies in unshipped files.
  • Setup remaining analyzer projects.
  • Finalize analyzer configuration.
Microsoft Reviewers: Open in CodeFlow

KlausLoeffelmann avatar Jun 10 '24 06:06 KlausLoeffelmann

Codecov Report

Attention: Patch coverage is 97.09677% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.84430%. Comparing base (c3cb9b3) to head (3cf1630). Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11515         +/-   ##
===================================================
+ Coverage   74.78710%   74.84430%   +0.05720%     
===================================================
  Files           3021        3012          -9     
  Lines         629289      629269         -20     
  Branches       46689       46692          +3     
===================================================
+ Hits          470627      470972        +345     
+ Misses        155301      154936        -365     
  Partials        3361        3361                 
Flag Coverage Δ
Debug 74.84430% <97.09677%> (+0.05720%) :arrow_up:
integration 18.03813% <ø> (+0.07912%) :arrow_up:
production 47.83718% <94.91525%> (+0.09464%) :arrow_up:
test 97.02004% <100.00000%> (+0.03443%) :arrow_up:
unit 44.86531% <94.91525%> (+0.00807%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 11 '24 07:06 codecov[bot]

@RussKie: I would very much appreciate if you - in the future - respect my ask to NOT start reviewing a draft PR, especially when I point out that it is not ready for review. I appreciate your valuable engagement, but if I am in the process to completely restructure this, (but still want to see at the end of the day, if pipelines pass), premature reviews generate too much useless noise comments, half of which become redundant, anyway.

UPDATE: No longer Draft.

KlausLoeffelmann avatar Jun 19 '24 06:06 KlausLoeffelmann