winforms icon indicating copy to clipboard operation
winforms copied to clipboard

fix issue 11450 Color contrast ratio of focus indicator over 'toolStripSplitButton1' is 1.247:1 which is less than 3:1: A11y_.NET CoreWinforms_StripControls_Toolstripwithmenuitem_NonTextContrast

Open Epica3055 opened this issue 1 year ago • 4 comments

Fixes #11450

Proposed changes

  • Remove RenderMode

Screenshots

Before

image

After

image

Test environment(s)

9.0.0-preview.6.24305.2

Microsoft Reviewers: Open in CodeFlow

Epica3055 avatar Jun 06 '24 09:06 Epica3055

@Epica3055 - had you investigated if other items have the same issue? Olina's team might be able to help out

Tanya-Solyanik avatar Jun 06 '24 18:06 Tanya-Solyanik

@Tanya-Solyanik @Epica3055 I tested this PR, found an issue: Now the drop-down triangle display for toolStripSplitButton and toolStripDropDownButton looks are same in StatusStrip. But actually in ToolStrip, they are same before.

Before: the drop-down triangle of toolStripSplitButton is bigger than toolStripDropDownButton's. The toolStripSplitButton drop-down triangle size in StatusStrip and ToolStrip keep consistent now image

After: the drop-down triangle size for toolStripSplitButton and toolStripDropDownButton looks are same in StatusStrip. The toolStripSplitButton in StatusStrip and ToolStrip keep consistent now image

Don't know why the toolstripSplitButton's dropdown triangle is displayed differently in StatusStrip.

Olina-Zhang avatar Jun 07 '24 03:06 Olina-Zhang

The failing tests have to be addressed.

ricardobossan avatar Jun 08 '24 23:06 ricardobossan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.39196%. Comparing base (aa61778) to head (53c5b85). Report is 150 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11502         +/-   ##
===================================================
- Coverage   74.41153%   74.39196%   -0.01958%     
===================================================
  Files           3030        3030                 
  Lines         628111      628041         -70     
  Branches       46824       46808         -16     
===================================================
- Hits          467387      467212        -175     
- Misses        157376      157484        +108     
+ Partials        3348        3345          -3     
Flag Coverage Δ
Debug 74.39196% <100.00000%> (-0.01958%) :arrow_down:
integration 17.98251% <ø> (-0.02134%) :arrow_down:
production 47.23002% <ø> (-0.02457%) :arrow_down:
test 96.96634% <100.00000%> (-0.02155%) :arrow_down:
unit 44.20535% <ø> (-0.03342%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 11 '24 09:06 codecov[bot]

@Tanya-Solyanik

winforms_PR_11502

Epica3055 avatar Jul 29 '24 09:07 Epica3055