winforms icon indicating copy to clipboard operation
winforms copied to clipboard

Color contrast ratio of focus indicator over 'toolStripSplitButton1' is 1.247:1 which is less than 3:1: A11y_.NET CoreWinforms_StripControls_Toolstripwithmenuitem_NonTextContrast

Open PoojaNamde opened this issue 1 year ago • 4 comments

.NET version

dotnet-sdk-9.0.100-preview.5.24258.1

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

GitHub Tags: #A11yMAS; #A11yTCS; #A11ySev2; #BM_.NET Core[Winforms]_Win32_May2024; #.NETCore; #WCAG1.4.11; #DesktopApp; #Win11; #FTP; #NonTextContrast;

Environment Details:

App name: .NET Core Winforms Window Version: Win 11 OS Build: 22621.3085

Repro Steps:

  1. Launch the "Accessibility core app".
  2. Main Form screen would appear.
  3. TAB to "MenuToolbars_Controls:Testing the controls under Menu Toolbars Tab" and hit ENTER key.
  4. TAB to StripControls button and hit ENTER key.
  5. TAB to 'toolStripSplitButton1' present at below section of the screen.
  6. Observe the issue.

Actual Result:

Color contrast ratio of focus indicator over 'toolStripSplitButton1' is 1.247:1 which is less than 3:1.

Similar issue is also observed in below scenario: Issue 1: ToolStripContainer

  1. Launch the "Accessibility core app".
  2. Main Form screen would appear.
  3. TAB to "MenuToolbars_Controls:Testing the controls under Menu Toolbars Tab" and hit ENTER key.
  4. TAB to ToolStripContainer button and hit ENTER key.
  5. TAB to 'toolStripSplitButton2' present at below section of the screen.
  6. Observe that color contrast ratio over "toolStripSplitButton2" is failing.

Issue2: PrintingTesting_PrintPreview:

  1. Launch the "Accessibility core app".
  2. Main Form screen would appear.
  3. TAB to "Printing_Controls:Testing the controls under Printing Tab" and hit ENTER key.
  4. TAB to Preview button and hit ENTER key.
  5. Print Preview Screen would appear.
  6. Navigate to "Zoom" button using TAB key and observe that color contrast ratio over "Zoom" is failing.

Expected Result:

Color contrast ratio of focus indicator over 'toolStripSplitButton1' should be greater than or equal to 3:1

User Impact:

Low vision users will not be able to identify where the focus is and will not be able to interact with the control.

Attachment

11450_A11y_ NET CoreWinforms_StripControls_Toolstripwithmenuitem_NonTextContrast

PoojaNamde avatar May 29 '24 16:05 PoojaNamde

GithubTags:#Rev:yaja;

Yash14j avatar May 31 '24 08:05 Yash14j

@LeafShi1 can you change the border of all selected ToolStripItems to a solid dark line? Make sure the contrast works in the high contrast themes as well.

merriemcgaw avatar Jun 04 '24 23:06 merriemcgaw

@Olina-Zhang Can your team help test whether other controls have the same problem?

LeafShi1 avatar Jun 07 '24 01:06 LeafShi1

@Olina-Zhang Can your team help test whether other controls have the same problem?

Other controls haven't this problem.

Olina-Zhang avatar Jun 12 '24 01:06 Olina-Zhang

@Epica3055 @Tanya-Solyanik is this on track for RC1?

merriemcgaw avatar Jul 25 '24 23:07 merriemcgaw

@Epica3055 Could you please upload latest App zip file to verify this issue.

PoojaNamde avatar Jul 31 '24 09:07 PoojaNamde

Verified this issue in the latest .NET 9.0.100-rc.1.24381.10, it was fixed: the color contrast ratio of focus indicator over 'toolStripSplitButton1' is greater than 3:1. image In addition, the default value of the RenderMode property of StatusStrip is now changed, 9.0 is changed to ManagerRenderMode by default, 8.0 is System. image

MandiMan avatar Aug 01 '24 06:08 MandiMan

@MandiMan Similar issues provided in repro steps are still reproducing. Please resolve these issues and reactivate this bug.

PoojaNamde avatar Aug 02 '24 09:08 PoojaNamde

@Epica3055 @PoojaNamde verified this issue on the main branch of the Winforms repo that Issue1(ToolStripContainer) of similar issues has been fixed, the color contrast ratio of focus indicator on 'toolStripSplitButton2' is greater than 3:1. image Issue2(PrintingTesting_PrintPreview) of similar issues still repro, the color contrast ratio of focus indicator on 'Zoom' is less than 3:1. image

MandiMan avatar Aug 07 '24 07:08 MandiMan

Verified the issue with .NET 9.0.100-rc.1.24422.10 test pass build that the issue has been fixed, which have the same results as mandi.

MelonWang1 avatar Aug 26 '24 07:08 MelonWang1

@MelonWang1 could you please share .NET 9.0.100-rc.1.24422.10 test pass build details to verify this issue.

PoojaNamde avatar Aug 26 '24 09:08 PoojaNamde

@PoojaNamde upload in here.

MelonWang1 avatar Aug 27 '24 09:08 MelonWang1

@MelonWang1 Verified both the issue in latest environment but issue is still reproducing.

Screenshot (1174)

Screenshot (1175)

PoojaNamde avatar Aug 27 '24 11:08 PoojaNamde

@PoojaNamde Please verify again using new upload file.

MelonWang1 avatar Aug 28 '24 02:08 MelonWang1

@MelonWang1 Verified this issue in latest build, issue is fixed for issue 1 but still reproducing for Issue 2. Please find the screenshot for reference. image

image

PoojaNamde avatar Aug 29 '24 15:08 PoojaNamde

@Epica3055 Reopened since issue 2 was not fixed.

MelonWang1 avatar Sep 04 '24 02:09 MelonWang1

@Epica3055 Could you please upload the latest build so that I can reverify the issue in latest build.

PoojaNamde avatar Sep 10 '24 05:09 PoojaNamde

@Epica3055 Could you please upload the latest build so that I can reverify the issue in latest build.

I uploaded the private dll to DotNet - WinForms - All Documents (sharepoint.com), please use PrivateBuildForTest to test

LeafShi1 avatar Sep 11 '24 07:09 LeafShi1

Verified this issue on latest WinForms repository from the main branch, and it has been resolved. The Issue2(PrintingTesting_PrintPreview) is no longer reproducible. As shown below, the color contrast ratio of the focus indicator on the 'Zoom' button exceeds the recommended 3:1 ratio. Screenshot 2024-09-12 065904

Syareel-Sukeri avatar Sep 12 '24 07:09 Syareel-Sukeri

#Closed; #Regressed:09-20-24;

Verified the bug in environment Bug is fixed and does not repro. Hence closing the bug. Please find the closing attachment

image

PoojaNamde avatar Sep 20 '24 10:09 PoojaNamde

breaking change issue - https://github.com/dotnet/docs/issues/43957

Tanya-Solyanik avatar Dec 13 '24 00:12 Tanya-Solyanik