winforms
winforms copied to clipboard
Fix ComponentModel.Design.serialization not support .Net8
Fixes #10425
Proposed changes
Restore support for BinaryFormatter in the designer-related classes. Restore serialization in:
- ExceptionCollection
- CodeDomSerializationStore
- CodeDomSerializerException
Customer Impact
- System.ComponentModel.Design.Serialization.SerializationStore.Save(Stream stream) can not suppport .NET8
Regression?
- Yes
Risk
- Minimal
Test methodology
- Manual
Accessibility testing
Test environment(s)
- 9.0.0-preview.2.24120.8
Microsoft Reviewers: Open in CodeFlow
Codecov Report
Attention: Patch coverage is 98.09160%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 73.62534%. Comparing base (
fccada2
) to head (49d50bb
). Report is 41 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10937 +/- ##
===================================================
+ Coverage 73.36695% 73.62534% +0.25838%
===================================================
Files 3094 3100 +6
Lines 632406 632300 -106
Branches 46857 46654 -203
===================================================
+ Hits 463977 465533 +1556
+ Misses 164981 163386 -1595
+ Partials 3448 3381 -67
Flag | Coverage Δ | |
---|---|---|
Debug | 73.62534% <98.09160%> (+0.25838%) |
:arrow_up: |
integration | 18.20812% <0.00000%> (-0.23993%) |
:arrow_down: |
production | 47.32297% <95.72650%> (+0.46365%) |
:arrow_up: |
test | 94.98374% <100.00000%> (+0.00063%) |
:arrow_up: |
unit | 44.37755% <95.72650%> (+0.60802%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
@LeafShi1 @Epica3055 @ricardobossan - please review this change, specifically compare this code to the InProc designer in the VS repo
@LeafShi1 @Epica3055 @ricardobossan - please review this change, specifically compare this code to the InProc designer in the VS repo
@Tanya-Solyanik The changes seem very familiar to those existing in InProc designer. For exemple, modified code for ExceptionCollection in this PR seems very similar to InProc, in https://devdiv.visualstudio.com/DevDiv/_git/VS?path=/src/vsip/Designer/Host/ExceptionCollection.cs
@SimonZhao888, sorry, we had mis-triaged this bug.