wcf icon indicating copy to clipboard operation
wcf copied to clipboard

Add wcfcore perf testing and deploy service with corewcf

Open ZhaodongTian opened this issue 3 years ago • 4 comments

Add perf testing with crank and deploy new service with corewcf. @HongGit @mconnew

ZhaodongTian avatar Aug 17 '22 08:08 ZhaodongTian

The WCFCorePerf and WCFCorePerfService is duplicate with the desktop version. What about rename WCFCorePerfService to CoreWCFService, and WCFCorePerf to WCFCorePerfClientUsingCoreWCFService (you could omit Service)?

HongGit avatar Aug 29 '22 05:08 HongGit

The WCFCorePerf and WCFCorePerfService is duplicate with the desktop version. What about rename WCFCorePerfService to CoreWCFService, and WCFCorePerf to WCFCorePerfClientUsingCoreWCFService (you could omit Service)? I have renamed the project name

ZhaodongTian avatar Aug 31 '22 01:08 ZhaodongTian

This PR looks like it has a lot of other unrelated changes included in it that were already merged. It's making it really difficult to review. Can you rebase to main?

mconnew avatar Sep 01 '22 20:09 mconnew

This PR looks like it has a lot of other unrelated changes included in it that were already merged. It's making it really difficult to review. Can you rebase to main?

I have rebased main and do a force push

ZhaodongTian avatar Sep 02 '22 01:09 ZhaodongTian

        string filePath = Path.Combine(Environment.CurrentDirectory, "WcfCorePerfCrankService.exe");

My understanding was we weren't going to be downloading anything any more and would always compile the perf crank service fresh each time.


Refers to: src/System.Private.ServiceModel/tests/Benchmarks/PerfUsingNetfxWCFService/NetfxWCFPerfService/Program.cs:35 in c7d5bf1. [](commit_id = c7d5bf17a854e04627f2655e908f371f0e1a2a31, deletion_comment = False)

mconnew avatar Oct 22 '22 00:10 mconnew

        string filePath = Path.Combine(Environment.CurrentDirectory, "WcfCorePerfCrankService.exe");

My understanding was we weren't going to be downloading anything any more and would always compile the perf crank service fresh each time.

Refers to: src/System.Private.ServiceModel/tests/Benchmarks/PerfUsingNetfxWCFService/NetfxWCFPerfService/Program.cs:35 in c7d5bf1. [](commit_id = c7d5bf1, deletion_comment = False)

@mconnew Crank only support .netcore and cannot build projects which target with .netframework. so I use download way to start service. do you know other way to host .netframewrok service?

ZhaodongTian avatar Oct 26 '22 09:10 ZhaodongTian