vscode-csharp
vscode-csharp copied to clipboard
Remove VSCode extension install retry workaround, use insiders for all tests
The retry loop workaround for microsoft/vscode#256031 is no longer needed as the issue has been fixed in vscode-insiders.
Changes
-
test/vscodeLauncher.ts: Remove the 5-attempt retry loop with 2s delays in
installExtensions() -
azure-pipelines.yml: Always use
insidersinstead of conditionally selecting stable/insiders based on build reason -
azure-pipelines/profiling.yml: Switch
testVSCodeVersionfromstabletoinsiders
Before
for (let attempts = 0; attempts < 5; attempts++) {
try {
await installExtension(extensionId, vscodeCli, vscodeArgs);
installSucceeded = true;
break;
} catch (error) {
console.warn(`Failed to install extension ${extensionId}; retrying: ${error}`);
installError = error;
await new Promise((resolve) => setTimeout(resolve, 2000));
}
}
After
for (const extensionId of extensionIds) {
await installExtension(extensionId, vscodeCli, vscodeArgs);
}
Original prompt
Remove the workaround here to call install extension in a loop - https://github.com/dotnet/vscode-csharp/blob/main/test/vscodeLauncher.ts#L72
The issue has been fixed in vscode-insiders. Update the azure-pipelines yaml and profiling yaml to use the insiders version
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
/azp run dotnet.vscode-csharp
Azure Pipelines successfully started running 1 pipeline(s).