vscode-csharp icon indicating copy to clipboard operation
vscode-csharp copied to clipboard

Add option to specify for roslyn server the razor output directory path

Open maryamariyan opened this issue 1 year ago • 1 comments

  • Adds devKitRazorOutputPath option
  • Allows RazorSourceGenerator to be picked up by tooling rather than SDK
  • Fixes WorkItem 1926900 (https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1926900)

/cc @CyrusNajmabadi @davidwengier @dibarbet Related to https://github.com/dotnet/roslyn/pull/72482

maryamariyan avatar Mar 11 '24 16:03 maryamariyan

Tested changes again for VS code and confirmed the problem goes away when project is targeting 6.0 and using 6.0 SDK.

Before change: image

After change: image

maryamariyan avatar Mar 13 '24 05:03 maryamariyan

The roslyn server version in vscode-csharp is not updated to a version that contains the server side change yet causing the failure on the CI.

[stderr] Unrecognized command or argument '--razorSourceGenerator'.
Unrecognized command or argument '/mnt/vss/_work/1/s/.razor/Microsoft.CodeAnalysis.Razor.Compiler.dll'.

Thanks @dibarbet for clarifying this

maryamariyan avatar Mar 25 '24 23:03 maryamariyan

/azp run

ryzngard avatar Mar 28 '24 22:03 ryzngard

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 28 '24 22:03 azure-pipelines[bot]