dotnet
VS parity: colorize different types differently
Currently VS code colorizes all types with the same color:
I find VS behaviour in this area a lot better since it colorizes different types differently, so just by looking at type I can immediately say, for instance, if it is a value type or reference type, which can be really helpful when working on perf-related problems:
I don't see any barriers for such thing to be in VS Code, since this is already an LSP feature (semantic tokens) and as far as I know it is already implemented in C# language server. Just need to tweak it to be able to differentiate types. And yeah, please be consistent and assign the same colors to these tokens as in VS for even better parity between IDEs
Back when semantic highlighting support was added to the C# extension we made an attempt to update the core themes with VS2019 colors. However, there was hesitancy due to a majority of VS Code users not being VS (or C#) users. We added the Visual Studio 2019 themes to the extension to provide this experience for our users. Hopefully more feedback like this will allow us to make the case that it is the right choice for customers.
Back when semantic highlighting support was added to the C# extension we made an attempt to update the core themes with VS2019 colors. However, there was hesitancy due to a majority of VS Code users not being VS (or C#) users. We added the Visual Studio 2019 themes to the extension to provide this experience for our users. Hopefully more feedback like this will allow us to make the case that it is the right choice for customers.
So if I read this right, the argument is, there is an alleged community that prefers less clarity in their syntax highlighting, so then therefore you need to apply a theme that doesn't work, because the semantic highlighting overwrites that as well?
It seems to me that the answer should be obvious that experienced uses can opt out/in to a theme (since they're experienced users...), and promoting clarity for general and new users should be higher priority. (whether or not those colors bear similarity to Visual Studio)
It's bizarre to me that making everything #9CDCFE is seen as a good thing, we might as well be using sublime or notepad.
@Kaerakh Please provide your feedback to the team that owns the in-box themes (https://github.com/microsoft/vscode/issues). We have provided the Visual Studio 2019 theme for users who want a different experience.