vscode-csharp icon indicating copy to clipboard operation
vscode-csharp copied to clipboard

Implement the "dotNetCliPaths" option to support custom .NET SDK locations

Open jkoritzinsky opened this issue 3 years ago • 5 comments

Depends on https://github.com/OmniSharp/omnisharp-roslyn/pull/2227

jkoritzinsky avatar Sep 02 '21 23:09 jkoritzinsky

... don't you need to register the option in package.json ?

SamB avatar Oct 31 '21 20:10 SamB

@SamB I did not realize I needed to do that. Done!

jkoritzinsky avatar Nov 03 '21 23:11 jkoritzinsky

@jkoritzinsky The c# extension also performs a check for dotnet to be on the PATH. Now that we are adding the ability to specify additional paths, can you update the getDotnetInfo function to return results when dotnet isn't on the path but instead specified by the new setting.

JoeRobich avatar Nov 03 '21 23:11 JoeRobich

The debugger also needs to find dotnet. So this directory probably needs to be added to PATH through DebugAdapterExecutable.options.env in createDebugAdapterDescriptor.

There are also build tasks that need to use dotnet, but I am not sure if there is a good way to add that to the PATH that VS Code uses, or if users would need to manually edit tasks.json.

gregg-miskelly avatar Nov 03 '21 23:11 gregg-miskelly

@gregg-miskelly @JoeRobich I've finally had a chance to get back to this PR. I've updated it to master and implemented both of your requests. Can you take another look when you have a chance?

jkoritzinsky avatar Jul 29 '22 20:07 jkoritzinsky

@JoeRobich @filipw can one of you merge this PR for me? Or is there something else I need to do before we get this merged in?

jkoritzinsky avatar Aug 22 '22 19:08 jkoritzinsky

@jkoritzinsky Sorry for the delay. Thanks again!

JoeRobich avatar Aug 23 '22 23:08 JoeRobich