try-convert icon indicating copy to clipboard operation
try-convert copied to clipboard

Set csproj property Deterministic to false if AssemblyVersion in AssemblyInfo.cs has wildcard

Open danielchalmers opened this issue 3 years ago • 1 comments

as mentioned in https://github.com/dotnet/upgrade-assistant/issues/546:

[...] If AssemblyInfo.cs is part of the project, check to see if wildcards are being used and properly set false in the new csproj.

Right now if you use a wildcard to automatically generate the version number, you won't be able to build after using try-convert until you disable determinism yourself.

danielchalmers avatar Jul 13 '21 14:07 danielchalmers

Seems like a reasonable addition. This might have to be one of the last steps in the migration piece. To do it right though, you'll need to parse the file and extract the version value with Roslyn. I suppose a bespoke parser could also get that data out. But either way, that's needed.

cartermp avatar Jul 14 '21 00:07 cartermp