sdk icon indicating copy to clipboard operation
sdk copied to clipboard

[release/10.0.2xx] Update dependencies from microsoft/testfx

Open dotnet-maestro[bot] opened this issue 1 month ago • 9 comments

This pull request updates the following dependencies

From https://github.com/microsoft/testfx

dotnet-maestro[bot] avatar Nov 25 '25 02:11 dotnet-maestro[bot]

Updated dependency versions in Version.Details.xml to resolve NU1109 package downgrade error in HotReload tests. @marcpopMSFT , @nagilson Could you please review and confirm if this approach looks good?

Error: test/Microsoft.DotNet.HotReload.Watch.Aspire.Tests/Microsoft.DotNet.HotReload.Watch.Aspire.Tests.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: Microsoft.CodeAnalysis.Features from 5.3.0-2.25560.14 to centrally defined 5.3.0-1.25568.105. Update the centrally managed package version to a higher version. Microsoft.DotNet.HotReload.Watch.Aspire.Tests -> Microsoft.CodeAnalysis.ExternalAccess.HotReload 5.3.0-2.25560.14 -> Microsoft.CodeAnalysis.Features (= 5.3.0-2.25560.14)

DonnaChen888 avatar Nov 27 '25 07:11 DonnaChen888

This PR is showing the same problem described here: https://github.com/dotnet/sdk/pull/52028#issuecomment-3618803130

The error log will show:

.dotnet/sdk/10.0.100/NuGet.targets(196,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) '[]' is not a valid version string.

MiYanni avatar Dec 06 '25 01:12 MiYanni

This PR is showing the same problem described here: #52028 (comment)

The error log will show:

.dotnet/sdk/10.0.100/NuGet.targets(196,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) '[]' is not a valid version string.

I'm not sure how this issue https://github.com/dotnet/sdk/pull/52028#issuecomment-3618803130 is the same. This branch defines hot reload packages in both of the version.details files. That issue in 52028 also manifested as a hot reload error, not as an error in the nuget targets. With that said, it could be an issue with the NuGet packages. However, this only seems to happen on the test fx branches and I'm not seeing it pop up in other PRs, nor did I see this specific error in the history of 52028. This leads me to think it's an issue with the test fx updates.

May you help explain? Do you think fixing the nuget package source will resolve the issue?

nagilson avatar Dec 09 '25 19:12 nagilson

Since the version string is missing, we do suspect it's a similar issue to a missing package.

nagilson avatar Dec 09 '25 21:12 nagilson

FYI @dotnet/dotnet-testing - code complete for .NET 10 is today, so if these changes are important we should really monitor this to make sure it goes through. This has been blocked from what I believe is an Arcade issue: https://github.com/dotnet/arcade-services/issues/5637 but I've applied what I hope will solve as a temporary workaround.

nagilson avatar Dec 10 '25 23:12 nagilson

Updated dependency versions in Version.Details.xml to resolve NU1109 package downgrade error in HotReload tests. @marcpopMSFT , @nagilson Could you please review and confirm if this approach looks good?

Error: test/Microsoft.DotNet.HotReload.Watch.Aspire.Tests/Microsoft.DotNet.HotReload.Watch.Aspire.Tests.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: Microsoft.CodeAnalysis.Features from 5.3.0-2.25560.14 to centrally defined 5.3.0-1.25568.105. Update the centrally managed package version to a higher version. Microsoft.DotNet.HotReload.Watch.Aspire.Tests -> Microsoft.CodeAnalysis.ExternalAccess.HotReload 5.3.0-2.25560.14 -> Microsoft.CodeAnalysis.Features (= 5.3.0-2.25560.14)

@DonnaChen888 Thanks - I appreciate your efforts here and this seemed good. This is likely due to a bug in the codeflow system which I filed above. This work around will only work temporarily, however, it's good to try to apply it to the failing branches to move stuff forward

nagilson avatar Dec 10 '25 23:12 nagilson

@nagilson @DonnaChen888 those changes are not critical, they update the version of MSTest and MTP that is used to test the code in the repo. It does not get included in the shipped product. (e.g. it does not affect the MSTest templates for new projects).

This PR is okay to not merge, or merge later.

https://grep.app/search?f.repo=dotnet%2Fsdk&q=MicrosoftTestingPlatformVersion

nohwnd avatar Dec 11 '25 07:12 nohwnd

Same issue as https://github.com/dotnet/sdk/pull/52053

Error: Assert.Matches() Failure: Pattern not found in value Regex: ".+Release\net10.0\TestProject(.dll|.exe)"··· Value: "C:\h\w\B97309BF\t\dotnetSdkTests\zyi10wu1.yi"···

DonnaChen888 avatar Dec 11 '25 09:12 DonnaChen888

Thanks, now what we're seeing is a testfx issue.

nagilson avatar Dec 12 '25 19:12 nagilson

Error: .dotnet\sdk\10.0.100\NuGet.targets(196,5): error : (NETCORE_ENGINEERING_TELEMETRY=Restore) '[]' is not a valid version string.

DonnaChen888 avatar Dec 16 '25 09:12 DonnaChen888

I think this needed https://github.com/dotnet/sdk/pull/52141/commits/7fe71a7aed46353b0339a925434d8d00d13891de

marcpopMSFT avatar Dec 17 '25 00:12 marcpopMSFT

Known issue: 52032 : Skipped test: Microsoft.NET.Build.Tests.GivenThatWeWantToBuildAWindowsRuntimeComponent.ManagedWinRTComponentCanBeReferenced

DonnaChen888 avatar Dec 18 '25 09:12 DonnaChen888