sdk icon indicating copy to clipboard operation
sdk copied to clipboard

CLI --self-contained description is wrong

Open adegeo opened this issue 2 months ago • 4 comments

It looks like https://github.com/dotnet/sdk/pull/32656 updated the --self-contained description incorrectly. The code change that triggered the old PR was actually related to the --runtime parameter no longer enforcing self-contained=true. It had nothing to do with the --self-contained option itself.

--self-contained is an option argument type and defaults to true when passed.

@baronfel

adegeo avatar Oct 01 '25 18:10 adegeo

@adegeo you'll need to update the xlf files on your fork to bump the translations. After that, you'll probably need to update the CLI snapshot tests.

baronfel avatar Oct 01 '25 18:10 baronfel

@baronfel I removed the lines from the translation files. I don't know what to do about the other item you said.

adegeo avatar Oct 06 '25 20:10 adegeo

Thank you @adegeo for driving the extra effort to fix the files and improve our docs by making a PR. And to @baronfel for adding help context.

I don't think we should expect our doc writers to be able to fix the tests on our repo. This should really be an automatable process and it is not a valuable use of human time/energy to fix either the xlf files or the completions snapshots. I've created https://github.com/dotnet/sdk/issues/51157 to see if the bot can write something to teach itself to do these tasks for us.

nagilson avatar Oct 07 '25 21:10 nagilson

@nagilson I assume this isn't for GA so we probably need to backport to 2xx or retarget to 2xx (whichever works).

marcpopMSFT avatar Oct 14 '25 23:10 marcpopMSFT