sdk Add trailing slash for -o Fixes #45682

Fixes #45682 by tweaking the value of the argument after it's parsed.

Apr 22 '25 20:04 Forgind

I tried this out in a more meaningful way, and it didn't work as I'd expected. It turns out CustomParsers don't really do anything as far as the output of the parser (??!!) because after it gets the result here, it just throws it away.

I'm restarting this PR but with a different change in a different place that should affect commands not connected with the template engine.

Apr 23 '25 03:04 Forgind

FYI @baronfel, I disabled zsh for the VerifyCompletions test. It's been getting a different answer on FullFramework than on other legs sometimes. I've seen it in two of my PRs, and tmat mentioned it in #48817 as well. Until someone has a chance to figure out why, I think we should just disable it.

May 14 '25 00:05 Forgind

FYI @baronfel, I disabled zsh for the VerifyCompletions test. It's been getting a different answer on FullFramework than on other legs sometimes. I've seen it in two of my PRs, and tmat mentioned it in #48817 as well. Until someone has a chance to figure out why, I think we should just disable it.

Did you disable it universally or just for full framework legs? If it's not a huge pain keeping it on for legs where it's working is a nice backstop.

May 14 '25 00:05 baronfel

FYI @baronfel, I disabled zsh for the VerifyCompletions test. It's been getting a different answer on FullFramework than on other legs sometimes. I've seen it in two of my PRs, and tmat mentioned it in #48817 as well. Until someone has a chance to figure out why, I think we should just disable it.

Did you disable it universally or just for full framework legs? If it's not a huge pain keeping it on for legs where it's working is a nice backstop.

I can try to make it framework-specific. It's currently all frameworks.

May 14 '25 17:05 Forgind

Note: PR is ready for review of the final changes. sounds like baronfel agreed with this approach to that test.

May 15 '25 18:05 marcpopMSFT

Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label.

Nov 24 '25 04:11 github-actions[bot]

This PR is perfectly good and should be ready to merge. Sorry I missed it being marked stale.

Dec 01 '25 04:12 Forgind