sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Move dotnet/format to dotnet/sdk

Open Cosifne opened this issue 1 year ago • 2 comments

This is generated based on 82edc548821f6f36fb4b8542ad47466d65a3a26a in dotnet/format repo. I pulled the commits from dotnet/format directly, so it will preserve all the history. Let me know if this is not OK. I get dotnet/format project locally build passed.

All commits before 592b10a are not interested. Mine commits are listed after that. I will put comments in interesting place to help review

Cosifne avatar Feb 17 '24 05:02 Cosifne

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Note: I deleted a lot of config files because I am not sure how these could still work in sdk repo, this is the list: .pre-commit-hooks.yaml Delete the azure-pipeline files, put the test job into one yml Remove .devcontainer Remove .vscode/* Remove ominishaprp.json Remove code of conduct Remove .github/CODEOWNER and .github/fabricBot.json Remove .config/tsaoptions.json Let me know if you feel any of them are still meaningful here

Cosifne avatar Feb 23 '24 02:02 Cosifne

I think it would be valuable to validated this change in the context of the VMR to unsure this doesn't break. A break would block the dependency from of the SDK into installer which is something to try to avoid. To validate:

  1. Pull the VMR locally

  2. Create a working branch

  3. Sync these change into the VMR using the https://github.com/dotnet/dotnet/blob/main/src/installer/eng/vmr-sync.sh script.

    <path to your local VMR>/vmr-sync.sh \
       --repository sdk:3e70a96b84932215a4e77bc2ec9c7b667e2a1679 \
       --sdk sdk:https://github.com/dotnet/sdk         \
       --tmp "$HOME/repos/tmp"
       --vmr "<path to your local VMR>
    

    cc @premun on usage of vmr-sync

    After syncing, you will want to remove this reference - https://github.com/dotnet/dotnet/blob/main/repo-projects/sdk.proj#L21

  4. Create a PR and let CI validate the change.

MichaelSimons avatar Mar 07 '24 19:03 MichaelSimons

VMR test PR https://github.com/dotnet/dotnet/pull/79

Cosifne avatar Mar 13 '24 21:03 Cosifne

VMR build passed

Cosifne avatar Mar 15 '24 17:03 Cosifne

@MiYanni Does sdk team prefer to keep the commit history from dotnet/format? Or should I squash all commits into one commit for a clean history?

Cosifne avatar Mar 15 '24 19:03 Cosifne

@Cosifne You can keep the history. That's fine. This PR cannot be merged, though, until after the preview snap, which I think is... Monday? You can confirm that with @marcpopMSFT

MiYanni avatar Mar 15 '24 19:03 MiYanni