sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Avoid extra copies of dotnet-watch build outputs in the SDK directory

Open tmat opened this issue 3 years ago • 7 comments

DotNetWatch.targets was copied to the output dir of redist.csproj and from there to multiple other directories where they shouldn't be.

tmat avatar Sep 16 '22 18:09 tmat

@dsplaisted PTAL. I wonder if other ProjectReferences in redist.csproj should also be Private=false.

tmat avatar Sep 16 '22 18:09 tmat

@javiercn

tmat avatar Sep 16 '22 20:09 tmat

Assuming the shipping layout is the same as in redist/dotnet directory the change affects it. It makes the SDK smaller by removing the duplicate files from the layout. There is logic in dotnet-watch to load Roslyn compiler assemblies from a common path shared with other tools. This logic is currently defeated by copying the binaries to the output directory.

If you think this is too risky I have no problem retargeting it to main.

tmat avatar Sep 20 '22 18:09 tmat

I think this is probably too risky at this point. All RC2 changes now require approval and the RTM branch won't have any more previews. We'll have a 7.0.2xx branch open in the coming weeks or main should be fine.

marcpopMSFT avatar Sep 21 '22 18:09 marcpopMSFT

Moving to main.

tmat avatar Sep 21 '22 19:09 tmat

/azp run

tmat avatar Sep 28 '22 20:09 tmat

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 28 '22 20:09 azure-pipelines[bot]

@dsplaisted Rebased to 7.0.2xx

tmat avatar Oct 10 '22 17:10 tmat