sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

[25961] - dotnet watch first key press fix

Open Tunduk opened this issue 3 years ago • 3 comments

Fixes #25961 Now dotnet-watch can't restart by Ctrl+R if watched process "take" Console, but I don't think that it is a problem.

Tunduk avatar Jul 28 '22 20:07 Tunduk

@baronfel Hi! Sorry to bother you but the issue is assigned to you. Maybe you can review this PR? It's really small and I am just afraid that PR won't get in .NET7 release

Tunduk avatar Aug 03 '22 18:08 Tunduk

Yes of course! Thank you for the ping - this just slipped my mind.

baronfel avatar Aug 03 '22 18:08 baronfel

This looks good to me, but I'd appreciate @mkArtakMSFT or @captainsafia taking a look, as they own watch.

baronfel avatar Aug 03 '22 21:08 baronfel

@baronfel Hi! Can I do something to push this PR forward?

Tunduk avatar Jan 29 '23 15:01 Tunduk

Thanks for your reply, @captainsafia ! I'll check if I can add a test for this. Should we ping somebody to update CODEOWNERS file?

Tunduk avatar Feb 22 '23 08:02 Tunduk

@tmat can you please review this? Thanks!

mkArtakMSFT avatar Feb 22 '23 22:02 mkArtakMSFT

Old PR review: This PR is more than a year old and does not appear to have active engagement. A reviewer has been notified offline to review and take action. If no action is taken, this PR will be closed in 14 days. Please comment if you want this PR left open for further investigation.

marcpopMSFT avatar Jan 26 '24 19:01 marcpopMSFT