sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Published 20 hours ago • verified publisher icon dotnet

Ensure case-insensitive web.config file name is used

Open scott-the-programmer opened this issue 5 years ago • 4 comments

Description

This PR attempts to resolve issue 14853

Currently, linux environments will fail to retrieve a Web.config file if the case does not match web.config. This results in the users version of Web.config from not being loaded and passed to WebConfigTransform, producing an incorrect result.

This PR fixes the issue by searching for the web.config file in the project directory, before passing it to the WebConfigTransform step

Tests

  • Added a series of "integration" tests for the TransformWebConfig task ✅
  • Test for regression on an OSX System ✅
  • Compile and test this on a Linux system (Kernel 5.4.78-1-lts) ✅
  • Test for regression on a Linux System ✅
  • Test for regression on a Windows System ✅

scott-the-programmer avatar Dec 06 '20 07:12 scott-the-programmer

CLA assistant check
All CLA requirements met.

dnfadmin avatar Dec 06 '20 07:12 dnfadmin

Commenter does not have sufficient privileges for PR 14854 in repo dotnet/sdk

azure-pipelines[bot] avatar Dec 07 '20 03:12 azure-pipelines[bot]

Hey @vijayrkn - would you be able to review this PR please? Thanks!

scott-the-programmer avatar Jan 27 '21 08:01 scott-the-programmer

@vijayrkn bump :)

scott-the-programmer avatar Jun 13 '21 07:06 scott-the-programmer

I have left one minor comment and once it is fixed, I will approve the change.

Thanks for reviewing @vijayrkn! Made the string comparison change and confirmed that the fix still works (tested on EndeavourOS Linux x86_64)

scott-the-programmer avatar Apr 13 '23 09:04 scott-the-programmer

@scott-the-programmer - All the tests have passed & I have merged the changes. Thank you for your contribution!

vijayrkn avatar Apr 14 '23 14:04 vijayrkn