samples icon indicating copy to clipboard operation
samples copied to clipboard

The root .editorConfig is missing VB configuration

Open paul1956 opened this issue 6 years ago • 2 comments

Before you open an issue

If the issue is:

Issue description The .EditorConfig file only has limited formatting rules for VB only below

[*.{cs,vb}]
charset = utf-8-bom
[*.vb]
# Modifier preferences
visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public,Friend,NotOverridable,Overridable,MustOverride,Overloads,Overrides,MustInherit,NotInheritable,Static,Shared,Shadows,ReadOnly,WriteOnly,Dim,Const,WithEvents,Widening,Narrowing,Custom,Async:suggestion

Target framework N/A Check the .NET target framework(s) being used, and include the version number(s).

  • [X] .NET Core
  • [X] .NET Framework
  • [X] .NET Standard

If using the .NET Core SDK, include dotnet --info output. If using .NET Framework without the .NET Core SDK, include info from Visual Studio's Help > About Microsoft Visual Studio dialog.

All the require style for VB samples is missing dotnet --info output or About VS info
<replace>

paul1956 avatar Jan 07 '20 11:01 paul1956

Does PR #1895 fix that ?

Youssef1313 avatar Jan 07 '20 13:01 Youssef1313

Looks very good maybe perfect. My only question is some of the options use C# terms like static or internal where VB uses Shared and Friend and those options are available in .editorConfig. Does something internal do the translation so that the shared setting work with both VB and C#, trying it out I seem to get the desired result in VB or at least get no suggestions.

paul1956 avatar Jan 09 '20 02:01 paul1956