runtime icon indicating copy to clipboard operation
runtime copied to clipboard

[browser][mt] Jiterp Failed to patch opcode

Open pavelsavara opened this issue 1 year ago • 2 comments

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Failed to patch opcode.*into a monitor point",
  "ExcludeConsoleLog": false
}

Reproduction Steps

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=551317

Log

[20:03:05] info: Failed to patch opcode at 4cc6190 into a monitor point

Known issue validation

Build: :mag_right: https://dev.azure.com/dnceng-public/public/_build/results?buildId=551317 Error message validated: Failed to patch opcode.*into a monitor point Result validation: :white_check_mark: Known issue matched with the provided build. Validation performed at: 2/3/2024 5:36:41 PM UTC

Report

Build Definition Test Pull Request
551317 dotnet/runtime WasmTestOnBrowser-System.Threading.Tests.WorkItemExecution dotnet/runtime#97868

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 1

pavelsavara avatar Feb 03 '24 17:02 pavelsavara

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details

Error Blob

{
  "ErrorMessage": "",
  "BuildRetry": false,
  "ErrorPattern": "Failed to patch opcode.*into a monitor point",
  "ExcludeConsoleLog": false
}

Reproduction Steps

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=551317

Log

[20:03:05] info: Failed to patch opcode at 4cc6190 into a monitor point
Author: pavelsavara
Assignees: kg
Labels:

arch-wasm, blocking-clean-ci, area-Codegen-Interpreter-mono, Known Build Error, os-browser

Milestone: 9.0.0

ghost avatar Feb 03 '24 17:02 ghost

@kg as discussed please

  • update the log message to contain value of the new opcode and the value of existing opcode after failed cmpxchg
    • so that we learn why it failed, why the racing opcodes are not the same value in the first place
    • if they are same, we should not produce the warning, because that's ok
  • update the comment about threading doesn't work
  • consider renaming "monitor point"

pavelsavara avatar Feb 03 '24 17:02 pavelsavara

This appears to be fixed

lewing avatar Jul 29 '24 17:07 lewing