runtime icon indicating copy to clipboard operation
runtime copied to clipboard

[browser] Use standard xunit test runner on multithreaded runtime

Open maraf opened this issue 2 years ago • 31 comments

  • Switch between threadless and standard xunit test runner based on runtime flavor being used
  • Pass logging level into the browser through xharness
  • Replace setting env var for logging xharness start with MSBuild property
  • WIP: Experimenting with runInParallel

Closes https://github.com/dotnet/runtime/issues/88763

maraf avatar Aug 30 '23 10:08 maraf

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: maraf
Assignees: maraf
Labels:

arch-wasm, os-browser

Milestone: -

ghost avatar Aug 30 '23 10:08 ghost

/azp run runtime-wasm

maraf avatar Aug 30 '23 10:08 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 30 '23 10:08 azure-pipelines[bot]

/azp run runtime-wasm

maraf avatar Aug 30 '23 11:08 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 30 '23 11:08 azure-pipelines[bot]

Are the xunit bits here just for testing? They should be with the rest of the runner stuff that we have in xharness.

radical avatar Aug 30 '23 14:08 radical

Are the xunit bits here just for testing? They should be with the rest of the runner stuff that we have in xharness.

Definitely. I'm also thinking about move the entry point to xharness as well. I copied it over to just be able to run CI with changes that I needed

maraf avatar Aug 31 '23 17:08 maraf

/azp run runtime-wasm

maraf avatar Sep 22 '23 06:09 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 22 '23 06:09 azure-pipelines[bot]

What is missing here ? Would this also work in ST build ? Is this still using blocking .Wait ?

pavelsavara avatar Oct 31 '23 17:10 pavelsavara

/azp run runtime-wasm

maraf avatar Nov 10 '23 13:11 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 10 '23 13:11 azure-pipelines[bot]

/azp run runtime-wasm

maraf avatar Nov 10 '23 18:11 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 10 '23 18:11 azure-pipelines[bot]

/azp run runtime-wasm

maraf avatar Nov 13 '23 10:11 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 13 '23 10:11 azure-pipelines[bot]

/azp run runtime-wasm

maraf avatar Nov 13 '23 14:11 maraf

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 13 '23 14:11 azure-pipelines[bot]

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

ghost avatar Dec 15 '23 17:12 ghost

Is this ready for review?

lewing avatar Jan 26 '24 17:01 lewing

/azp run runtime-wasm

maraf avatar Jan 29 '24 08:01 maraf

/azp run runtime-wasm

maraf avatar Jan 29 '24 12:01 maraf

/azp run runtime-wasm

maraf avatar Jan 29 '24 12:01 maraf

With thread ID logging

[13:53:59] info: 	[STRT][1467] System.Text.Json.Serialization.Tests.ConstructorTests_Span.Class_MultiplePublicParameterizedCtors_NoPublicParameterlessCtor_NoAttribute_NotSupported
[13:53:59] info: 	[PASS][1467] System.Text.Json.Serialization.Tests.ConstructorTests_Span.Class_MultiplePublicParameterizedCtors_NoPublicParameterlessCtor_NoAttribute_NotSupported
[13:53:59] info: 	[STRT][1467] System.Text.Json.Serialization.Tests.ConstructorTests_Span.MultipleTypes
[13:53:59] info: 	[PASS][1473] System.Text.Json.Serialization.Tests.ConstructorTests_Span.MultipleTypes
[13:53:59] info: 	[STRT][1473] System.Text.Json.Serialization.Tests.ConstructorTests_Span.PathForChildPropertyFails
[13:53:59] info: 	[PASS][1473] System.Text.Json.Serialization.Tests.ConstructorTests_Span.PathForChildPropertyFails

maraf avatar Jan 30 '24 08:01 maraf

/azp run runtime-wasm

maraf avatar Jan 30 '24 08:01 maraf

/azp run runtime-wasm

maraf avatar Jan 30 '24 12:01 maraf

/azp run runtime-wasm

maraf avatar Jan 30 '24 16:01 maraf

CI was stuck, merged main to restart

lewing avatar Jan 31 '24 02:01 lewing

/azp run runtime-wasm

maraf avatar Jan 31 '24 08:01 maraf

Requires https://github.com/dotnet/runtime/pull/97640

maraf avatar Feb 07 '24 18:02 maraf