runtime icon indicating copy to clipboard operation
runtime copied to clipboard

[wasm][debugger] Removed internalProperties group.

Open ilonatommy opened this issue 3 years ago • 3 comments

Fixes https://github.com/dotnet/runtime/issues/75778.

Motivation: https://github.com/dotnet/runtime/issues/75778#issuecomment-1252541452.

It fixes a bug from net 7, so will need backporting.

ilonatommy avatar Sep 20 '22 16:09 ilonatommy

Tagging subscribers to 'arch-wasm': @lewing See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes https://github.com/dotnet/runtime/issues/75778.

Motivation: https://github.com/dotnet/runtime/issues/75778#issuecomment-1252541452.

It fixes a bug from net 7, so will need backporting.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: 7.0.0

ghost avatar Sep 20 '22 16:09 ghost

/backport to release/7.0-rc2

ilonatommy avatar Sep 20 '22 16:09 ilonatommy

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3091753776

github-actions[bot] avatar Sep 20 '22 16:09 github-actions[bot]

If the tests are passing, LGTM.

thaystg avatar Sep 20 '22 16:09 thaystg

/backport to release/7.0-rc2

ilonatommy avatar Sep 20 '22 16:09 ilonatommy

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3091794256

github-actions[bot] avatar Sep 20 '22 16:09 github-actions[bot]

@ilonatommy just curious, is VS using the privateProperties part?

radical avatar Sep 21 '22 03:09 radical

Also, it would be a good idea to remove all the __* fields that we add to the json for our consumption, before sending them out from the proxy. The tests shouldn't depend on any of those.

radical avatar Sep 21 '22 04:09 radical

@ilonatommy just curious, is VS using the privateProperties part?

It is using it in the meaning: they are displayed. However, the difference between them and result is not stressed in VS - in Browser it is. To visualise, here are two screenshots from the same class in VS and Browser: image

image

ilonatommy avatar Sep 21 '22 08:09 ilonatommy

Also, it would be a good idea to remove all the __* fields that we add to the json for our consumption, before sending them out from the proxy. The tests shouldn't depend on any of those.

I agree and Thays already mentioned this idea as well. The PR with it will be out soon.

ilonatommy avatar Sep 21 '22 08:09 ilonatommy