runtime icon indicating copy to clipboard operation
runtime copied to clipboard

Update heap hard limit for large pages

Open cshung opened this issue 3 years ago • 3 comments

Fixes #54616

This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.

cshung avatar Aug 06 '22 01:08 cshung

Tagging subscribers to this area: @dotnet/gc See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54616

This bug is for segments only, some of the segment size calculations may increase the total size allocated. To make sure all allocated memory can be used (without being limited by the heap hard limit), the heap hard limit should be increased to match the allocated memory.

Author: cshung
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

msftbot[bot] avatar Aug 06 '22 01:08 msftbot[bot]

since this only affects certain platforms now, is it worth taking for 7?

mangod9 avatar Aug 06 '22 01:08 mangod9

since this only affects certain platforms now, is it worth taking for 7?

One way or the other, we need to get this bug out of 7.0.0. We can either fix it, won't fix it, or move the bug to 8. Here are some info helpful for the decision:

  • This is a corner case, it is unexpected for workloads to run under segments and using large pages and specified a hard limit that is not aligned.
  • But this is fatal, if it is not specified correctly, the startup or subsequent virtual commit calls will fail.

Let me know what we want to do with this bug.

cshung avatar Aug 06 '22 21:08 cshung

lets move to 8 for now and then we can determine what to do then.

mangod9 avatar Aug 12 '22 01:08 mangod9

/backport to release/7.0

cshung avatar Jan 27 '23 20:01 cshung

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4027925993

github-actions[bot] avatar Jan 27 '23 20:01 github-actions[bot]