dotnet
Make synthesized primary constructor baking field return the original parameter as an associated symbol
@CyrusNajmabadi Please review from IDE and Analyzers perspective (all affected places are properly adjusted, etc.)
There are about 30 use sites for FieldSymbol.AssociatedSymbol, I think they should be explicitly examined, and each should either be adjusted, or an explanation should be provided why the current code is good. Targeted tests for the use sites are also needed, when possible. For each use-site, I suggest either making an appropriate code change (when necessary), or adding an appropriate assert and a comment explaining why the code is fine for the new API behavior. This way reviewers will be able to review actions taken for each use site. Feel free to use other ways to present information about the call sites. Then, we should "pull on the thread" and Identify what other APIs change behavior (for example IFieldSymbolInternal.AssociatedSymbol), and perform the same for them. And continue the cycle until all affected APIs are covered.
To clarify, I would ignore use-sites in tests.