roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Disable TransitiveVersioningPinning for RoslynAnalyzers.

Open JoeRobich opened this issue 7 months ago • 4 comments

For RoslynAnalyzer which are intended to run on older builds of the compiler, we do not want to pin transitive package versions as that would break compatibility.

This PR introduces a Directory.Packages.props to the src/RoslynAnalyzers folder to disable transitive pinning. As a follow up we could remove the redundant M.CA.* package references from the RoslynAnalyzer projects as it is no longer necessary to include them to override their version.

Resolves #78702

JoeRobich avatar May 29 '25 05:05 JoeRobich

For RoslynAnalyzer which are intended to run on older builds of the compiler,

I would love to discuss this. How far back do we truly intend on supporting things. I feel like it shoudl be fine, every now and then, to 'reset' the support point. Basically, we can always tell people:

  1. if you really need to support older systems, use these older nuget packages of RoslynAnalyzers.
  2. We then move forward, and say: from this point on, the furthest backward support point is now X.

Indefinite backward support is a high tax, and it makes us spend all this time contorting code. Given our resourcing, and an existing solution for users who need to move more slowly, maybe it is time to ditch this?

CyrusNajmabadi avatar Jun 18 '25 16:06 CyrusNajmabadi

/azp run

JoeRobich avatar Jun 18 '25 17:06 JoeRobich

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 18 '25 17:06 azure-pipelines[bot]

Resolves #78702

It looks like you linked an area issue, did you mean to link https://github.com/dotnet/roslyn/issues/78695 instead?

jjonescz avatar Jun 19 '25 08:06 jjonescz

Resolves #78702

It looks like you linked an area issue, did you mean to link #78695 instead?

Thanks! I have no idea how that happened. =)

JoeRobich avatar Jun 19 '25 16:06 JoeRobich

I would love to discuss this. How far back do we truly intend on supporting things.

@CyrusNajmabadi I will bring you into the internal chat about this.

jaredpar avatar Jun 19 '25 17:06 jaredpar

This change merged as part of https://github.com/dotnet/roslyn/pull/79030/files#diff-48fe7b4023cb6c25478d1b0b6dd3c66d51a37d1ee950582dd1c5bc4ca9caad59R9

JoeRobich avatar Jul 15 '25 02:07 JoeRobich