roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Update source-build team references

Open MichaelSimons opened this issue 1 year ago • 3 comments

The @dotnet/source-build-internal team is being deprecated. All references to it were updated.

Included the renaming of SourceBuild.props to the new naming convention, DotNetBuild.props.

Related to dotnet/source-build#4645

Repo admins, please grant @dotnet/product-construction and @dotnet/source-build write access. You can remove access granted to @dotnet/source-build-internal.

MichaelSimons avatar Oct 16 '24 21:10 MichaelSimons

@MichaelSimons GitHub is flagging this file as having errors as the teams being flagged aren't visible, is that expected?

jasonmalinowski avatar Oct 16 '24 21:10 jasonmalinowski

@MichaelSimons GitHub is flagging this file as having errors as the teams being flagged aren't visible, is that expected?

That's because of the note I included in the PR descriptions:

Repo admins, please grant @dotnet/product-construction and @dotnet/source-build write access. You can remove access granted to @dotnet/source-build-internal.

The validation is failing because the code owners must have write access.

MichaelSimons avatar Oct 16 '24 21:10 MichaelSimons

@MichaelSimons Ah apologies, missed that last bit!

jasonmalinowski avatar Oct 16 '24 21:10 jasonmalinowski

Gentle ping @dotnet/roslyn-infrastructure. Can you please make the requested permission changes so that this PR can be merged? TIA

Repo admins, please grant @dotnet/product-construction and @dotnet/source-build write access. You can remove access granted to @dotnet/source-build-internal.

MichaelSimons avatar Oct 23 '24 13:10 MichaelSimons

@jaredpar

jjonescz avatar Oct 23 '24 14:10 jjonescz

Added the teams with write permission.

jaredpar avatar Oct 23 '24 18:10 jaredpar