roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Overload Resolution Priority

Open 333fred opened this issue 1 year ago • 1 comments

This implements the Overload Resolution Priority language feature.

Test Plan: https://github.com/dotnet/roslyn/issues/74131 Champion issue: https://github.com/dotnet/csharplang/issues/7706 Speclet: https://github.com/dotnet/csharplang/blob/main/proposals/overload-resolution-priority.md

333fred avatar Jun 27 '24 20:06 333fred

This feature is small enough that, rather than do a full feature branch with multiple PRs, I've just done it as a single PR. I don't really recommend a commit-by-commit review here, I'll go through and comment on the actually interesting parts of the implementation. Most of it is actually just tests and attribute decoding boilerplate.

333fred avatar Jun 27 '24 20:06 333fred

@cston addressed or answered your comments, please take another look. @jcouv for review.

333fred avatar Jul 01 '24 17:07 333fred

@jcouv addressed feedback

333fred avatar Jul 03 '24 23:07 333fred

| Overload Resolution Priority | PR not yet available | In Progress | 333fred | jcouv, cston | Not yet assigned | 333fred |

~~Could be moved at the bottom of the C# 13 table, since the feature is now attached to new language version. Or would you rather wait until VB is done to make that change?~~ Never mind. I was confused by the diff. I see the entry in the C# 13 section #Closed


Refers to: docs/Language Feature Status.md:13 in c0c1730. [](commit_id = c0c1730bc56c8b6a8286a2af0aefb334795d99f6, deletion_comment = False)

jcouv avatar Jul 09 '24 18:07 jcouv